error: useless use of `vec!` --> src/steps.rs:359:21 | 359 | let parts = vec![ | _____________________^ 360 | | self.options.url.with_suffix("/"), 361 | | self.options.core.clone(), 362 | | "/select?wt=json&indent=off&omitHeader=true".to_string(), ... | 366 | | selected.to_string(), 367 | | ]; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[deny(clippy::useless_vec)]` implied by `#[deny(warnings)]` help: you can use an array directly | 359 ~ let parts = [self.options.url.with_suffix("/"), 360 + self.options.core.clone(), 361 + "/select?wt=json&indent=off&omitHeader=true".to_string(), 362 + format!("&q={}", filter), 363 + sort, 364 + self.transfer.get_param("&"), 365 ~ selected.to_string()]; |

error: usage of a legacy numeric constant --> src/steps.rs:312:51 | 312 | schema.num_found.min(self.limit.unwrap_or(std::u64::MAX)) | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants help: use the associated constant instead | 312 | schema.num_found.min(self.limit.unwrap_or(u64::MAX)) | ~~~~~~~~

error: the borrowed expression implements the required traits --> src/save.rs:43:38 | 43 | let zip_file = zip_path.join(&zip_name); | ^^^^^^^^^ help: change this to: `zip_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[deny(clippy::needless_borrows_for_generic_args)]` implied by `#[deny(warnings)]`

error: casting the result of `isize::abs()` to usize --> src/helpers.rs:147:25 | 147 | let ulast_pos = last_pos.abs() as usize; | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `last_pos.unsigned_abs()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned = note: `#[deny(clippy::cast_abs_to_unsigned)]` implied by `#[deny(warnings)]`

error: manual implementation of `Option::map` --> src/argscompletion.rs:47:33 | 47 | let path: Option<PathBuf> = match output_dir { | _________________________________^ 48 | | Some(dir) => Some(dir.join(shell.file_name(&app))), 49 | | None => None, 50 | | }; | |_____^ help: try: `output_dir.as_ref().map(|dir| dir.join(shell.file_name(&app)))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[deny(clippy::manual_map)]` implied by `#[deny(warnings)]`

error: unneeded `return` statement --> src/argscompletion.rs:41:5 | 41 | return raise("No output directory specified to output manpage"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[deny(clippy::needless_return)]` implied by `#[deny(warnings)]` help: remove `return` | 41 - return raise("No output directory specified to output manpage"); 41 + raise("No output directory specified to output manpage") |

error: usage of a legacy numeric constant --> src/args.rs:392:21 | 392 | "max" => Ok(std::u64::MAX), | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants note: the lint level is defined here --> src/main.rs:1:9 | 1 | #![deny(warnings)] | ^^^^^^^^ = note: `#[deny(clippy::legacy_numeric_constants)]` implied by `#[deny(warnings)]` help: use the associated constant instead | 392 | "max" => Ok(u64::MAX), | ~~~~~~~~

The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

could not compile `solrcopy` (bin "solrcopy") due to 8 previous errors

Clippy had exited with the 101 exit code

The job was canceled because "ubuntu-latest" failed.

The operation was canceled.

The job was canceled because "ubuntu-latest" failed.

The operation was canceled.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/