Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random tensor sizes in tests #6

Open
wavepacket opened this issue Oct 9, 2013 · 2 comments
Open

Use random tensor sizes in tests #6

wavepacket opened this issue Oct 9, 2013 · 2 comments

Comments

@wavepacket
Copy link

Just a comment to not forget it: There was recently a bug in trace() with incorrect calculation of indexes. This was not captured by the unit tests, because it only happened for unsymmetric tensor shapes, while the tests use only equal sizes for all dimensions.

So suggestion: When iterating over tensors of different ranks and sizes in the tests, use unsymmetric (random?) tensor shapes.

@juanjosegarciaripoll
Copy link
Owner

test_over_tensors() in loops.h now iterates over tensors of different sizes and ranks. Is this what you meant?

@wavepacket
Copy link
Author

I am not sure. I can say for certain that the bug mentioned in my original posting referred to commit dfdef4d, but I cannot fathom what I originally meant here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants