You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While translating Wavepacket to the cmake branch of the tensor library, I noticed a behavior change.
Previously, tensor::scprod(a, b) would calculate b^* \cdot a ("mathematician's" scalar product convention. Now, it is the other way around ("physicist's" convention), where the complex conjugate is taken from a.
As a physicist with backwards-compatibility concerns, I have no strong opinion either way. But it should be either reverted or marked as a breaking change.
The text was updated successfully, but these errors were encountered:
While translating Wavepacket to the cmake branch of the tensor library, I noticed a behavior change.
Previously, tensor::scprod(a, b) would calculate b^* \cdot a ("mathematician's" scalar product convention. Now, it is the other way around ("physicist's" convention), where the complex conjugate is taken from a.
As a physicist with backwards-compatibility concerns, I have no strong opinion either way. But it should be either reverted or marked as a breaking change.
The text was updated successfully, but these errors were encountered: