Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scprod has changed behavior in cmake branch #33

Open
wavepacket opened this issue May 22, 2023 · 0 comments
Open

scprod has changed behavior in cmake branch #33

wavepacket opened this issue May 22, 2023 · 0 comments

Comments

@wavepacket
Copy link

While translating Wavepacket to the cmake branch of the tensor library, I noticed a behavior change.

Previously, tensor::scprod(a, b) would calculate b^* \cdot a ("mathematician's" scalar product convention. Now, it is the other way around ("physicist's" convention), where the complex conjugate is taken from a.

As a physicist with backwards-compatibility concerns, I have no strong opinion either way. But it should be either reverted or marked as a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant