Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDF has a few issues #11

Open
wavepacket opened this issue Mar 17, 2014 · 0 comments
Open

SDF has a few issues #11

wavepacket opened this issue Mar 17, 2014 · 0 comments

Comments

@wavepacket
Copy link

Just looking at the serialization code in sdf.h, I spot a few problems:

  • the base class DataFile does not declare anything as virtual. Is this intended?
  • My use case: I just store an arbitrary, ad-hoc unknown number of CTensors. So in principle, it would be useful to somehow get information about when you reached the end of the file. That is complicated with the current code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wavepacket