feat: allow setting node registration expiration via config #2280
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswiggins
requested review from
ohdearaugustin,
nblock,
juanfont and
kradalby
as code owners
chriswiggins
force-pushed
the
feat/configurable-registration-cache
branch
from
2f8caf0 to
7f739b4
Compare
chriswiggins
force-pushed
the
feat/configurable-registration-cache
branch
from
7f739b4 to
7518eba
Compare
kradalby
reviewed
Dec 12, 2024
There was a problem hiding this comment.
This looks fine, I think this actually opens for us to test this, which it isnt atm.
Maybe like a variant of https://github.com/juanfont/headscale/blob/main/integration/auth_web_flow_test.go#L73, where the login flow has a wait to ensure they timeout so they are cleaned up and out of the cache and therefor fail. You can override the setting with a quite short expiry.
Comment on lines
+944
to
+945
| NodeRegistrationCacheExpiration: viper.GetDuration("tuning.node_registration_cache_expiration"), | ||
| NodeRegistrationCacheCleanup: viper.GetDuration("tuning.node_registration_cache_cleanup"), |
There was a problem hiding this comment.
I think these should be "nestable" in yaml, so
Suggested change
| NodeRegistrationCacheExpiration: viper.GetDuration("tuning.node_registration_cache_expiration"), | |
| NodeRegistrationCacheCleanup: viper.GetDuration("tuning.node_registration_cache_cleanup"), | |
| NodeRegistrationCacheExpiration: viper.GetDuration("tuning.node_registration_cache.expiration"), | |
| NodeRegistrationCacheCleanup: viper.GetDuration("tuning.node_registration_cache.cleanup"), |
but its fine to keep them as fields in go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't done any unit / integration tests yet as I'd like to be pointed in the right direction with where it should be.
Fixes #2277