Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position resets when navigating back to previous route #4

Open
jtormey opened this issue Jul 23, 2024 · 5 comments
Open

Scroll position resets when navigating back to previous route #4

jtormey opened this issue Jul 23, 2024 · 5 comments

Comments

@jtormey
Copy link
Owner

jtormey commented Jul 23, 2024

Steps to recreate

  1. Have enough channels so that scrolling down is possible
  2. Scroll down and select a channel
  3. Navigate back, see scroll position snap to top when view re-mounts

Likely requires upstream changes in https://github.com/liveview-native/liveview-client-swiftui

cc @bcardarella

@jtormey jtormey added this to the ElixirConf US 2024 milestone Jul 23, 2024
@jtormey jtormey added the bug Something isn't working label Jul 23, 2024
@bcardarella
Copy link
Collaborator

@jtormey Carson and I were talking about this today, there is a possible solution for < iOS 18 but considering that iOS 18 will be out in early September and iOS adoption rate is usually very high we've decided to punt in favor of the iOS >= 18 implementation that will come in LVN v0.4.

I'd be open to debating the merits of this decisoin if someone can show good data on slower than accepted adoption rate or if there are good reasons why some apps or organizations cannot use iOS 18 when it is available.

@bcardarella
Copy link
Collaborator

Sorry, didn't mean to close on your repo 😱

@bcardarella
Copy link
Collaborator

This is the branch that enables it liveview-native/liveview-client-swiftui#1389

@jtormey
Copy link
Owner Author

jtormey commented Jul 23, 2024

Thank you for the quick response! I'll close this once I update the app to iOS 18 and confirm the fix.

@carson-katri
Copy link
Contributor

Scroll restoration is implemented for all iOS versions support by LVN in this PR: liveview-native/liveview-client-swiftui#1394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants