Bug Report #12331 #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVDA does not announce the names of the menus when walking with left and right arrows in iTunes. This can potentially be fixed by adding a class which helps accesses the text inside of an iTunes menu box. The function added below will attempt to provide that functionality. Further additions are above which add an object of this class to the clsList in chooseNVDAObjectOverlayClasses. A comment was not made on the bug report due to the issue unaffecting the user experience in any way and tight scheduling. Considering I have not contributed to NVDA before, this implementation may be going off the rails. However, I think I have provided a decent foundation in solving this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVDA does not announce the names of the menus when walking with left and right arrows in iTunes. This can potentially be fixed by adding a class which helps accesses the text inside of an iTunes menu box. The function added below will attempt to provide that functionality. Further additions are above which add an object of this class to the clsList in chooseNVDAObjectOverlayClasses. A comment was not made on the bug report due to the issue unaffecting the user experience in any way and tight scheduling. Considering I have not contributed to NVDA before, this implementation may be going off the rails. However, I think I have provided a decent foundation in solving this issue.
Link to issue number:
nvaccess#12331
Summary of the issue:
NVDA does not announce the titles of menu boxes when clicking through them using the keyboard.
Description of how this pull request fixes the issue:
By adding a class which helps accesses the text inside of an iTunes menu box. The class contains functions that will attempt to provide that functionality. Further additions are above which add an object of this class to the clsList in chooseNVDAObjectOverlayClasses.
Testing strategy:
Automated tests given through NVDA's source code and local system functionality.
Known issues with pull request:
No known issues with the automated tests. Local testing of NVDA seemed to now read the titles of menu boxes as well. However, I am not sure if my code incorporated the fix, or if simply restarting my computer and rebuilding NVDA accomplished the goal.
Change log entries:
New features: Menu titles are announced back to the user in iTunes
Changes: Added a class that gets added to "clsList" which is the structure that handles announcing text
Bug fixes: Bug report nvaccess#12331
For Developers: I am a beginning developer with NVDA and believe my implementation may be going off the rails. However, this solution could incorporate some foundation in another solution, or further prove the bug does not exist.
Code Review Checklist: