Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests missing from PyPI #21

Open
jtojnar opened this issue Oct 19, 2018 · 5 comments
Open

Tests missing from PyPI #21

jtojnar opened this issue Oct 19, 2018 · 5 comments

Comments

@jtojnar
Copy link

jtojnar commented Oct 19, 2018

I am trying to package pyuca for NixOS but cannot run tests because the PyPI package lacks them.

See also the Debian thread about the issue:
https://lists.debian.org/debian-python/2016/04/msg00074.html

@jtauber
Copy link
Owner

jtauber commented Oct 19, 2018

I don't think the tests should ship with the package normally. Is there a workaround I can help with?

@jtojnar
Copy link
Author

jtojnar commented Oct 19, 2018

I think you are supposed to include the unit test into the tarball but not into the wheel.

Looking through the packaging docs, I could not find anything mentioning whether to include tests into the tarball. The following StackOverflow answers suggest they are supposed to be included:

https://stackoverflow.com/a/16444257/160386
https://stackoverflow.com/a/32391295/160386
https://stackoverflow.com/a/14437754/160386

Out of top 15 packages on PyPI, only three (pip, awscli and colorama) do not include tests in the tarballs so it seems to be common practice.

@jtauber
Copy link
Owner

jtauber commented Oct 20, 2018

yep, makes sense to include them in a source distribution. I just need to work out how to now :-)

@jtojnar
Copy link
Author

jtojnar commented Oct 20, 2018

Requests seem to add it through MANIFEST.in: https://github.com/requests/requests/blob/master/MANIFEST.in

@pgajdos
Copy link

pgajdos commented Jun 4, 2019

I can second that. Unit tests can be used by packagers to test the distro package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants