-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find/Extract do not detect keys in .html files - in angular NX MonoRepo with Shared Root Transloco Config #81
Comments
@seadonk Can you please share a small reproduction? would you like to make a PR for it? 🙂 |
@shaharkazaz |
I'm facing the same issue, did you find a solution @seadonk ? |
@jbchr No, sorry. I haven't had time to look into it. If I get a chance I'll make a new minimal reproduction. |
@jbchr You are welcome to give it a shoot as well 🙂 |
Current behavior
In our NX monorepo, we use a root transloco.config file for all apps/libraries, with the translations sitting at
<project>/src/assets/i18n
. Transloco-keys-manager FIND and EXTRACT methods do not detect any keys in the template (.html) files and will show them as extra keys.Expected behavior
All keys in .html files for both libs and apps should be detected by the FIND and EXTRACT commands.
Steps To Reproduce
Here is an example based off your transloco-with-nx-libs repo.
https://github.com/seadonk/transloco-with-nx-libs
Screenshots
Behavior in an APP:
If you run
transloco-keys-manager find --project transloco-holder
, it will correctly identify the existing keys and also missing key and extra key.Behavior in an LIB:
If you run yarn find --project transloco-lib-a, it will identify extra key, but not missing key, and it will incorrectly think that gps is an extra key because it does not see it in the template.
Keys manager config
Environment
Debug logs
Additional context
Add any other context about the problem here.
Contribution
I would like to make a pull request for this feature:
[ ] Yes! 🚀
[ ] Maybe next time
The text was updated successfully, but these errors were encountered: