Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support multiline extraction in .ts or .html #154

Open
1 task done
akhildhanuka opened this issue Mar 16, 2023 · 2 comments
Open
1 task done

Feature: Support multiline extraction in .ts or .html #154

akhildhanuka opened this issue Mar 16, 2023 · 2 comments
Labels
enhancement New feature or request PRs welcome

Comments

@akhildhanuka
Copy link

akhildhanuka commented Mar 16, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Is this a regression?

Yes

Current behavior

            <a href="mailto:[email protected]?Subject=issue%20{{ logId }}" target="_top">{{transloco('Send us a ' +
                'report')}}</a>

Expected behavior

'Send us a report' key should be recognised and added to pot file... but this is not being recognised.

Please provide a link to a minimal reproduction of the bug

https://stackblitz.com/edit/transloco-keys-manager-mulitline-issue?file=src%2Fapp%2Fapp.component.ts,package.json

cannot provide

Transloco Config

No response

Debug Logs

No response

Please provide the environment you discovered this bug in

Transloco: 
Transloco Keys Manager:
Angular:
Node: 
Package Manager: 
OS:

Additional context

No response

I would like to make a pull request for this bug

No
@stackblitz
Copy link

stackblitz bot commented Mar 16, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@shaharkazaz shaharkazaz added the enhancement New feature or request label Mar 18, 2023
@shaharkazaz shaharkazaz changed the title Bug: extract fails to recognise any keys which are multiline in .ts or .html Feature: Support multiline extraction in .ts or .html Mar 18, 2023
@shaharkazaz
Copy link
Collaborator

@akhildhanuka You are welcome to open a PR for it.

Bisara96 added a commit to Bisara96/transloco-keys-manager that referenced this issue Apr 21, 2023
@Bisara96
feat: 🎸 TS extraction support for multiline keys
225e3ee 
Added extraction support for concatenated keys on multiple lines

✅ Closes: jsverse#154
Bisara96 added a commit to Bisara96/transloco-keys-manager that referenced this issue Apr 21, 2023
@Bisara96
feat: 🎸 Support multline concatenated key extraction
c027bf8 
Added support for extraction of keys concatenated on multiple lines in
typescript file and template structural directive.

✅ Closes: jsverse#154
Bisara96 added a commit to Bisara96/transloco-keys-manager that referenced this issue Apr 21, 2023
@Bisara96
test: 💍 Updated tests for multiline support jsverse#154
bc587c9 
✅ Closes: jsverse#154
This was referenced Apr 21, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request PRs welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhildhanuka @shaharkazaz