Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for NO_COLOR env var #143

Open
1 task done
emzet opened this issue Aug 19, 2022 · 0 comments
Open
1 task done

Feature: Add support for NO_COLOR env var #143

emzet opened this issue Aug 19, 2022 · 0 comments
Labels
enhancement New feature or request PRs welcome

Comments

@emzet
Copy link

emzet commented Aug 19, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe

Please add support for NO_COLOR environment variable https://no-color.org/ to disable colorful output and emojis in console which does not support it. Also useful for CI environments. Currently there are hardcoded colors in source code:

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/keys-detective/compare-keys-to-files.ts#L28

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/keys-detective/compare-keys-to-files.ts#L107

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/keys-detective/index.ts#L23

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/keys-builder/index.ts#L19

https://github.com/ngneat/transloco-keys-manager/blob/d2c84d974a55c4fea3deb86a33bcd3feb259f272/src/keys-builder/create-translation-files.ts#L59

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/keys-detective/build-table.ts#L32

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/keys-detective/build-table.ts#L81

https://github.com/ngneat/transloco-keys-manager/blob/d8e739e1566d820dc91c9de11d8d9ad053d2c552/src/utils/keys.utils.ts#L37

Describe the solution you'd like

add either support for NO_COLOR environment variable or add new option flag in CLI

Describe alternatives you've considered

No response

Describe alternatives you've considered

N/A

Describe alternatives you've considered

N/A

Additional context

No response

I would like to make a pull request for this feature

No

@shaharkazaz shaharkazaz added enhancement New feature or request PRs welcome labels Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PRs welcome
Projects
None yet
Development

No branches or pull requests

2 participants