From 0ea25704bf2cb46dce7b26ade60f16f380113d88 Mon Sep 17 00:00:00 2001 From: Jeffrey Stedfast Date: Wed, 18 Dec 2024 10:47:54 -0500 Subject: [PATCH] Marked IX509CertificateDatabase.Update(X509CrlRecord) as obsolete There is no reason that I can think of to update a CRL record. --- MimeKit/Cryptography/IX509CertificateDatabase.cs | 1 + MimeKit/Cryptography/SqlCertificateDatabase.cs | 1 + MimeKit/Cryptography/X509CertificateDatabase.cs | 2 ++ 3 files changed, 4 insertions(+) diff --git a/MimeKit/Cryptography/IX509CertificateDatabase.cs b/MimeKit/Cryptography/IX509CertificateDatabase.cs index 9d711b3c5f..8759fdf127 100644 --- a/MimeKit/Cryptography/IX509CertificateDatabase.cs +++ b/MimeKit/Cryptography/IX509CertificateDatabase.cs @@ -183,6 +183,7 @@ public interface IX509CertificateDatabase : IStore, IDisposable /// Updates the specified fields of the record in the database. /// /// The CRL record. + [Obsolete ("This method is not used and will be removed in a future release.")] void Update (X509CrlRecord record); /// diff --git a/MimeKit/Cryptography/SqlCertificateDatabase.cs b/MimeKit/Cryptography/SqlCertificateDatabase.cs index 0bfa7d6956..4e94baa676 100644 --- a/MimeKit/Cryptography/SqlCertificateDatabase.cs +++ b/MimeKit/Cryptography/SqlCertificateDatabase.cs @@ -876,6 +876,7 @@ protected override DbCommand GetUpdateCommand (DbConnection connection, X509Cert /// The database command. /// The database connection. /// The CRL record. + [Obsolete ("This method is not used and will be removed in a future release.")] protected override DbCommand GetUpdateCommand (DbConnection connection, X509CrlRecord record) { var statement = new StringBuilder ("UPDATE ").Append (CrlsTableName).Append (" SET "); diff --git a/MimeKit/Cryptography/X509CertificateDatabase.cs b/MimeKit/Cryptography/X509CertificateDatabase.cs index 08de0397e7..ae4e7e2633 100644 --- a/MimeKit/Cryptography/X509CertificateDatabase.cs +++ b/MimeKit/Cryptography/X509CertificateDatabase.cs @@ -887,6 +887,7 @@ protected static object GetValue (X509CrlRecord record, string columnName) /// The database command. /// The database connection. /// The CRL record. + [Obsolete ("This method is not used and will be removed in a future release.")] protected abstract DbCommand GetUpdateCommand (DbConnection connection, X509CrlRecord record); /// @@ -1211,6 +1212,7 @@ public void Remove (X509CrlRecord record) /// /// is . /// + [Obsolete ("This method is not used and will be removed in a future release.")] public void Update (X509CrlRecord record) { if (record == null)