Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

Stop using knockout to observe individual VM properties. In fact, remove it from Dataserve. #12

Open
jsplink opened this issue Aug 11, 2015 · 4 comments
Assignees
Milestone

Comments

@jsplink
Copy link
Owner

jsplink commented Aug 11, 2015

Stuff like this...

        self.offset = ko.observable(0);
        self.hasMore = ko.observable(true);
        self.limit = ko.observable(args.limit);
        self.order = ko.observable(args.order);
        self.triggers = args.tiggersMore;
        self.list = ko.observableArray([]);
        self.filteredList = ko.observableArray([]);
        self.loading = ko.observable(true); // in the process of loading

...is dirty. Knockout should only be used for viewModel < - > browserDOM bindings. In fact, remove it from dataserve completely.

RxJS for make that transaction on the fly.

@jsplink
Copy link
Owner Author

jsplink commented Aug 11, 2015

Get rid of filteredList. Add or remove filter helpers from the list's filter method as a strategic component of the associated RxJS observations.

@jsplink
Copy link
Owner Author

jsplink commented Aug 11, 2015

Apply the arguments to the ComputerQuery with a fresh object extension instead of including this tiring piece.

@jsplink
Copy link
Owner Author

jsplink commented Aug 11, 2015

Create a required mixin which abstracts these boilerplate require calls.

@jsplink
Copy link
Owner Author

jsplink commented Aug 11, 2015

Abstract AppConfig from dataserve and rename it to app.json. Make it an RxJS thing.

@jsplink jsplink modified the milestone: 0.1.0 Aug 11, 2015
@jsplink jsplink self-assigned this Jan 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant