Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the samples files from the conformance tests zip. #123

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

netdpb
Copy link
Collaborator

@netdpb netdpb commented Dec 19, 2023

Depends on jspecify/jspecify#438.

Helps to decouple this build from JSpecify.

Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, modulo the CI failure...

@netdpb
Copy link
Collaborator Author

netdpb commented Dec 20, 2023

Thanks, looks good, modulo the CI failure...

That should be just because the other PR wasn't merged.

…in the branch we're on. Otherwise depend on `../jspecify/samples`.
…ctoryTest` assumes the directories are "within" the `tests` subdirectory.
@netdpb netdpb changed the title Use the samples files from the conformance tests zip if it's there. Use the samples files from the conformance tests zip. Dec 20, 2023
@netdpb netdpb requested a review from wmdietl December 20, 2023 19:29
Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer with the updated samples branch and CI passes.

@netdpb netdpb merged commit a72549c into jspecify:main Dec 20, 2023
2 checks passed
@netdpb netdpb deleted the ct-samples branch December 20, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants