Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run conformance tests first, and jspecifySamplesTest second. #114

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Run conformance tests first, and jspecifySamplesTest second. #114

merged 1 commit into from
Nov 29, 2023

Conversation

netdpb
Copy link
Collaborator

@netdpb netdpb commented Nov 28, 2023 •
edited
Loading

Check out jspecify/main and run conformance tests first. Then checkout samples-google-prototype and run jspecifySamplesTest second.

This will allow us to make the check lifecycle task depend on the conformance test tasks, which will mean that build will run them too.

@netdpb
Check out jspecify/main and run conformance tests first. Then check…
cb87329 
… out samples-google-prototype and run `jspecifySamplesTest` second.
@netdpb netdpb requested a review from cpovirk November 28, 2023 23:26
@netdpb netdpb mentioned this pull request Nov 28, 2023
Merged
@netdpb netdpb added the conformance-tests Framework and implementation for conformance tests label Nov 29, 2023
@netdpb netdpb merged commit 91e888a into jspecify:main Nov 29, 2023
2 checks passed
@netdpb netdpb deleted the checkout-main branch November 29, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpovirk cpovirk cpovirk approved these changes

Assignees
No one assigned
Labels
conformance-tests Framework and implementation for conformance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netdpb @cpovirk