Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy Rubocop #2

Open
mms-pl opened this issue Feb 22, 2020 · 7 comments
Open

Support legacy Rubocop #2

mms-pl opened this issue Feb 22, 2020 · 7 comments

Comments

@mms-pl
Copy link

mms-pl commented Feb 22, 2020

Thanks for fixing bundler :)

However, the extension still doesn't work for me:

RuboCop[19:37:35.502000] Found RuboCop 0.51.0 (Bundled)

RuboCop[19:37:37.847000] invalid option: --no-display-cop-names
/Users/msapka/.rbenv/versions/2.3.8/lib/ruby/gems/2.3.0/gems/rubocop-0.51.0/lib/rubocop/options.rb:19:in `parse'
/Users/msapka/.rbenv/versions/2.3.8/lib/ruby/gems/2.3.0/gems/rubocop-0.51.0/lib/rubocop/cli.rb:27:in `run'
/Users/msapka/.rbenv/versions/2.3.8/lib/ruby/gems/2.3.0/gems/rubocop-0.51.0/bin/rubocop:13:in `block in <top (required)>'
/Users/msapka/.rbenv/versions/2.3.8/lib/ruby/2.3.0/benchmark.rb:308:in `realtime'
/Users/msapka/.rbenv/versions/2.3.8/lib/ruby/gems/2.3.0/gems/rubocop-0.51.0/bin/rubocop:12:in `<top (required)>'
/Users/msapka/.rbenv/versions/2.3.8/bin/rubocop:22:in `load'
/Users/msapka/.rbenv/versions/2.3.8/bin/rubocop:22:in `<main>'

I'm 99% sure that this means Rubocop we are using is too old for this fancy option.

@jsmecham
Copy link
Owner

Eek. Good to know! Will add some checks for RuboCop version and support for this option.

@mms-pl
Copy link
Author

mms-pl commented Feb 22, 2020

Thank you :)

Since I'd love to use this plugin in my daily work, would be possible to specify any ETA? Like: days, weeks, next time I've got free afternoon?

@jsmecham
Copy link
Owner

Try now (in 0.3.1). I went ahead and reverted the change where I enabled that flag on the rubocop in favor of stripping it out manually.

@mms-pl
Copy link
Author

mms-pl commented Feb 23, 2020

The process runs, so yeah this is fixed. Thank you ;)

However, I now experience the same problem as in jsmecham/nova-eslint#2

@mms-pl
Copy link
Author

mms-pl commented Feb 24, 2020

FYI: I've bumped Rubocop tp 0.80.0 in few of our repositories, and the errors are marked in editor.

@jsmecham
Copy link
Owner

Thanks for the update. I'm going to try stepping back through older versions of RuboCop to see if I can fix it for older versions, as well.

@martinstreicher
Copy link

martinstreicher commented Sep 16, 2020

I installed Nova and opened a Ruby project with a .rubocop.yml and a Gemfile. However, Rubocop does not seem to be policing my changes as I edit the code and/or save the file. I have Rubocop 0.91.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants