Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use speech_recognition_msgs instead of jsk_gui_msgs #36

Closed
wants to merge 1 commit into from
Closed

use speech_recognition_msgs instead of jsk_gui_msgs #36

wants to merge 1 commit into from

Conversation

furushchev
Copy link
Member

This is related with jsk-ros-pkg/jsk_common#610 and #1.
We intend to move GUI related messages (jsk_gui_msgs) to upstream.

@k-okada
Copy link
Member

k-okada commented Dec 6, 2014

If we move jsk_gui_msgs to upstream does that include VoiceMessage message? or are you going to remove that?

@furushchev
Copy link
Member Author

I think It depends on the generality of messages.
VoiceMessage, for example, is now more generalized messages, not only used with smart phone, so I think it' better to graduate as independent message. (and it is speech_recognition_msgs). (Also I doubt this message is related to jsk_"GUI"_msgs)
Of cource, gui_msgs is still needed because of gui specific messages such as Swipe or some gui specified messages.
Anyway, I think, VoiceMessage is now not needed for jsk_gui_msgs, because we should now use more common message speech_recognition_msgs.

@k-okada
Copy link
Member

k-okada commented Dec 6, 2014

in that case, we do not need entire jsk_gui_msgs, for example Imu is more
general message, camera is as well, I think there are no message that only
used smart_gui. So basic idea of jsk_gui_msgs is to provide set of sensor
message that is provided from smart phone and that should correspond to
some class of android SDK (and may be iphone SDK as well),

so you're proposing that we should consider the smart phone as robot,
they're collection of sensors and we do not define the set of available
sensors for Android/iPhone. That's ok, so please create apk and upload to
GooglePlay, and also tell @kochigami that there are API breaking changes.

◉ Kei Okada

On Sat, Dec 6, 2014 at 3:06 PM, Furushchev [email protected] wrote:

I think It depends on the generality of messages.
VoiceMessage, for example, is now more generalized messages, not only used
with smart phone, so I think it' better to graduate as independent message.
(and it is speech_recognition_msgs). (Also I doubt this message is related
to jsk_"GUI"_msgs)
Of cource, gui_msgs is still needed because of gui specific messages such
as Swipe or some gui specified messages.
Anyway, I think, VoiceMessage is now not needed for jsk_gui_msgs, because
we should now use more common message speech_recognition_msgs.


Reply to this email directly or view it on GitHub
#36 (comment)
.

@furushchev
Copy link
Member Author

OK. To create apk seems to be really tough work, but I try to do it.
And, when I make jsk_gui_msgs deprecated, I'll inform her.

@garaemon garaemon force-pushed the master branch 2 times, most recently from 02c3d80 to ccaca6a Compare January 20, 2015 17:47
@k-okada
Copy link
Member

k-okada commented Nov 27, 2015

what was the conclusion of this discussion?

@furushchev
Copy link
Member Author

Sorry for late response.
I think it would be better to migrate message that is used as speech recognition from jsk_gui_msgs to speech_recognition_msgs.
message of speech_recognition_msgs includes all functionality of the one of jsk_gui_msgs, so we can just substitute messsage name to use in android codes, but there is no test environment. When I find time to make document to build android project, I'll do this migration.

@k-okada
Copy link
Member

k-okada commented Nov 29, 2015

ok, move to #63

@k-okada k-okada closed this Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants