Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always make pqpmodel for detailed shape #125

Merged
merged 1 commit into from
Jul 17, 2015

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Jul 16, 2015

Always make pqpmodel for detailed shape according to euslisp/jskeus#232

snozawa added a commit that referenced this pull request Jul 17, 2015
Always make pqpmodel for detailed shape
@snozawa snozawa merged commit c291aa1 into jsk-ros-pkg:master Jul 17, 2015
@k-okada
Copy link
Member

k-okada commented Jul 17, 2015

humm, it complicated

  • qhull-faceset -> convex hull faceset, used for geometric representation
  • gl-vertices -> original mesh , used for gl display
  • :make-collision-model-for-links -> only supported in euscollada robot?

@snozawa
Copy link
Contributor Author

snozawa commented Jul 17, 2015

:make-collision-model-for-links -> only supported in euscollada robot?

Exactly.

qhull-faceset -> convex hull faceset, used for geometric representation
gl-vertices -> original mesh , used for gl display

Currently, not.
gl-vertices is used for gl display, detailed geometric representation,
and currently used for collision checking like self-collision-cehck.
qhull-faceset is used for simple geometric representation.

We already discussed about this.

  • :make-collision-model-for-links method should be moved to irteus and supported in irteus level. However, curretly detailed geometric representation can be obtain gl-vertices and obtaining collision shape from "GL" something is strange. So, we need to rename gl-vertices or refine these structures.
  • We need to discuss to add simple geometry and detailed geometry to some classes in irteus level such as bodyset and body classes. It would be better to remove gl-vertices from irteus. Collision program and gl program just use common detailed geometry slot variables.

Related PR and isseue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants