Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a date+time to the HTML error pages (error_template.html) #32

Open
jypeter opened this issue Nov 21, 2019 · 1 comment
Open

Add a date+time to the HTML error pages (error_template.html) #32

jypeter opened this issue Nov 21, 2019 · 1 comment

Comments

@jypeter
Copy link

jypeter commented Nov 21, 2019

The current HTML error page does not specify a time, and you just get something like

Sorry, Atmosphere_Surface has failed for comparison PMIP4_0k_ref :(
Try the following checks:
[...]

Knowing when the error occurred (and when the page was generated) is a useful information, e.g.

Sorry, Atmosphere_Surface has failed for comparison PMIP4_0k_ref :(

An error occurred on Thu Nov 21 17:07:18 2019

Try the following checks:
[...]

I have just noticed that the comparison pages that are successfully generated don't mention their creation date, so this information should probably also be added

It is probably just a matter of making a small change in share/fp_template/error_template.html

<h1>Sorry, target_component has failed for comparison target_comparison :(</h1>
<p>An error occurred on error_time</p>
<h2>Try the following checks:</h2>

and in share/fp_template/copy_html_error_page.sh

current_date=`date`
sed -i "s/error_time/${error_time}/g" ${atlas_pathfilename}
@jservonnat
Copy link
Owner

@jypeter ok, please setup a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants