Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoMethodError undefined method get_header re-emerged with JRuby Rack 1.2.2 #259

Open
chadlwilson opened this issue Jun 11, 2024 · 5 comments · May be fixed by #262
Open

NoMethodError undefined method get_header re-emerged with JRuby Rack 1.2.2 #259

chadlwilson opened this issue Jun 11, 2024 · 5 comments · May be fixed by #262
Milestone
1.2.3

Comments

@chadlwilson
Copy link
Contributor

chadlwilson commented Jun 11, 2024 •
edited
Loading

jruby-rack 1.2.x seems to barf while running on app that was previously working fine with

  • Java 21
  • JRuby 9.4.7.0
  • Rails 6.1 w/ Sprockets 4.2.1 and Rack 2.2.9
  • jruby-rack 1.1.22
  • Jetty 10.0.21 embedded servlet container, Jetty initializing RackServlet and indirectly JRuby runtimes.
NoMethodError (undefined method `get_header' for #<Rack::Handler::Servlet::DefaultEnv:0xfb5b374>):

This seems to be a re-emergence of #211, previously fixed by #212 in 1.1.21 to create Rails 5.x compatibility, but merged only to the 1.1 branch. Not sure if intentional, but might need some cherry-picks back to master for this and possibly others? https://github.com/jruby/jruby-rack/compare/1.1-stable

Happy to try and help where I can if so. I would like to see how to move forward on master to figure out #244 and others so having some working CI of some sort from master helps.
@headius
Copy link
Member

headius commented Jun 11, 2024

previously fixed by #212 in 1.2.21

I assume you mean 1.1.21?

Could you put together a new PR based on #212 that applies it to master? Alternatively we could review the "big merge" I attempted in #253 and pull in everything that was not merged.

@headius headius added this to the 1.2.3 milestone Jun 11, 2024
@headius
Copy link
Member

headius commented Jun 11, 2024

We can also release a 1.1.x release now that the fix for #247 has been fixed there as well, if we want a smaller target for the moment.

@chadlwilson
Copy link
Contributor Author

previously fixed by #212 in 1.2.21

I assume you mean 1.1.21?

Ahh yes, sorry. Too many version numbers 😔

@chadlwilson chadlwilson changed the title NoMethodError undefined method get_header'` re-emerged with JRuby Rack 1.2.2 NoMethodError undefined method get_header' re-emerged with JRuby Rack 1.2.2 Jun 11, 2024
@chadlwilson chadlwilson changed the title NoMethodError undefined method get_header' re-emerged with JRuby Rack 1.2.2 NoMethodError undefined method get_header re-emerged with JRuby Rack 1.2.2 Jun 11, 2024
@chadlwilson
Copy link
Contributor Author

We can also release a 1.1.x release now that the fix for #247 has been fixed there as well, if we want a smaller target for the moment.

Personally I'm not too worried about that particular fix, so am neutral on releasing that branch unless the intent was to also get that in a CIed state of some sort 😅

Was more looking to move forward with a branch that seems to be receiving some love, and was making the naive assumption that the intent of releasing 1.2.x was an attempt to move forward with this branch as primary - without noticing your earlier #253 PR which I guess implicitly acknowledges that there are likely a lot of regressions on 1.2/master in comparison to 1.1 until the mega merge is done.

If I PR the #212 fix I suspect we'll end up playing whack-a-mole for various issues long since fixed on 1.1 folks have been relying on for years?

@headius
Copy link
Member

headius commented Jun 11, 2024

I don't think it would take much effort to get another 1.1.x release out with the #247 fix, but I think both @kares and I would at least like to toward 1.2 being the release path going forward. We will discuss and see what makes the most sense right now.

@chadlwilson chadlwilson linked a pull request Jul 18, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.3
Development

Successfully merging a pull request may close this issue.

Merge 1.1 into master (redux) chadlwilson/jruby-rack
2 participants
@headius @chadlwilson