From 7719e28c7e9bc598a4299cd7a38e75641ab21041 Mon Sep 17 00:00:00 2001
From: Haozhun Jin <hjin@fb.com>
Date: Wed, 25 Mar 2015 17:45:49 -0700
Subject: [PATCH] Check the validity of all mbc created

---
 src/org/joni/OptMapInfo.java              | 7 ++++++-
 src/org/joni/Parser.java                  | 3 +++
 src/org/joni/ast/StringNode.java          | 6 ++++++
 src/org/joni/exception/ErrorMessages.java | 1 +
 4 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/org/joni/OptMapInfo.java b/src/org/joni/OptMapInfo.java
index 9d3574b7..02329b2b 100644
--- a/src/org/joni/OptMapInfo.java
+++ b/src/org/joni/OptMapInfo.java
@@ -21,6 +21,8 @@
 
 import org.jcodings.CaseFoldCodeItem;
 import org.jcodings.Encoding;
+import org.joni.exception.ErrorMessages;
+import org.joni.exception.ValueException;
 
 final class OptMapInfo {
 
@@ -61,7 +63,10 @@ void addCharAmb(byte[]bytes, int p, int end, Encoding enc, int caseFoldFlag) {
 
         byte[] buf = new byte[Config.ENC_CODE_TO_MBC_MAXLEN];
         for (int i=0; i<items.length; i++) {
-            enc.codeToMbc(items[i].code[0], buf, 0);
+            int len = enc.codeToMbc(items[i].code[0], buf, 0);
+            if (enc.length(buf, 0, len) < 0) {
+                throw new ValueException(ErrorMessages.ERR_INVALID_UNICODE);
+            }
             addChar(buf[0], enc);
         }
     }
diff --git a/src/org/joni/Parser.java b/src/org/joni/Parser.java
index 419993fc..ab19499d 100644
--- a/src/org/joni/Parser.java
+++ b/src/org/joni/Parser.java
@@ -683,6 +683,9 @@ private Node parseExp(TokenType term) {
         case CODE_POINT:
             byte[]buf = new byte[Config.ENC_CODE_TO_MBC_MAXLEN];
             int num = enc.codeToMbc(token.getCode(), buf, 0);
+            if (enc.length(buf, 0, num) < 0) {
+                newValueException(ERR_INVALID_UNICODE);
+            }
             // #ifdef NUMBERED_CHAR_IS_NOT_CASE_AMBIG ... // setRaw() #else
             node = new StringNode(buf, 0, num);
             break;
diff --git a/src/org/joni/ast/StringNode.java b/src/org/joni/ast/StringNode.java
index 15ed04cf..26d6b990 100644
--- a/src/org/joni/ast/StringNode.java
+++ b/src/org/joni/ast/StringNode.java
@@ -22,6 +22,8 @@
 import org.jcodings.Encoding;
 import org.joni.Config;
 import org.joni.constants.StringType;
+import org.joni.exception.ErrorMessages;
+import org.joni.exception.ValueException;
 
 public final class StringNode extends Node implements StringType {
 
@@ -154,7 +156,11 @@ public void cat(byte c) {
 
     public void catCode(int code, Encoding enc) {
         ensure(Config.ENC_CODE_TO_MBC_MAXLEN);
+        int oldEnd = end;
         end += enc.codeToMbc(code, bytes, end);
+        if (enc.length(bytes, oldEnd, end) < 0) {
+            throw new ValueException(ErrorMessages.ERR_INVALID_UNICODE);
+        }
     }
 
     public void clear() {
diff --git a/src/org/joni/exception/ErrorMessages.java b/src/org/joni/exception/ErrorMessages.java
index 683ff62e..f72b22b4 100644
--- a/src/org/joni/exception/ErrorMessages.java
+++ b/src/org/joni/exception/ErrorMessages.java
@@ -89,5 +89,6 @@ public interface ErrorMessages extends org.jcodings.exception.ErrorMessages {
     final String ERR_INVALID_COMBINATION_OF_OPTIONS = "invalid combination of options";
     final String ERR_OVER_THREAD_PASS_LIMIT_COUNT = "over thread pass limit count";
     final String ERR_TOO_BIG_SB_CHAR_VALUE = "too big singlebyte char value";
+    final String ERR_INVALID_UNICODE = "invalid unicode";
 
 }