Fully format the code base with google-java-format #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also took the opportunity to: - Add google-java-format as an automatic check when `mvn verify` is run (and by extension, automatically making it a Travis CI check). - Upgrade the pom.xml and .travis.yml to run and compile against Java 8 minimum (since the POM was still assuming a minimum of Java 6, and the Travis config was still testing against Java 7 JDKs). - Set up a default Maven goal, so that contributors now only need to run `mvn` to run `mvn clean verify` by default, which is probably what they want to check that their contributions work. - Upgrade some Maven plugin versions. - Update the contribution guidelines accordingly.
Closed
|
Wow, GitHub's diff continues to stun me with its inaccuracy. :P Thanks for setting this up. :) |
Indeed. 😛
You're welcome @jrtom! Many thanks for reviewing this. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86.
As described in the commit message, I also took the opportunity to:
mvn verifyis run (and by extension, automatically making it a Travis CI check).mvnto runmvn clean verifyby default, which is probably what they want to check that their contributions work.