Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderContext cleanup #105

Open
9 tasks
jrtom opened this issue Aug 6, 2017 · 0 comments
Open
9 tasks

RenderContext cleanup #105

jrtom opened this issue Aug 6, 2017 · 0 comments

Comments

@jrtom
Copy link
Owner

jrtom commented Aug 6, 2017

  • a bunch of places assume that various Predicates or Functions can be null. Either use Optional or require them to be present instead. (Or mark as @nullable.)
  • maybe don’t even have getBlahPredicate()/getBlahTransformer(); just expose isBlah()/applyBlah() instead
  • edgeIncludePredicate() should just go ahead and check the edge’s endpoints as well so that the caller doesn’t have to
  • edgeArrowPredicate/Transformer: just have something that provides an Optional Arrow for a given edge (get rid of the Predicate)
    • or a boolean that specifies for the entire RenderContext whether edge arrows are wanted
  • figure out whether we want “? super V” or not
  • use java.util.Function and .Predicate instead of their Guava counterparts
  • consider making instance variables in PluggableRendererContext private instead of protected
  • add @Override annotations
  • add documentation for each method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant