Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding wrong inputs #27

Open
jpgattuso opened this issue Aug 19, 2016 · 2 comments
Open

Avoiding wrong inputs #27

jpgattuso opened this issue Aug 19, 2016 · 2 comments

Comments

@jpgattuso
Copy link
Owner

@jamesorr

I thought about your question about how we could make sure that users provide parameters in the right unit. We could make a test and provide a warning if, say:

  • DIC is outside the range 140e-6 to 3000e-6
  • TA is outside the range 600e-6 to 3000e-6
  • Sit is outside the range 0 to 300e-6
  • Pt is outside the range 0 to 5e-6

These ranges are estimates based on GLODAP v2.

What do you think?

Jean-Pierre

@jamesorr
Copy link
Collaborator

@jpgattuso

I suggest to widen the ranges for DIC and TA so as to be more inclusive of estuaries and extremes in coastal and marginal seas, tide pools, etc.

For the low end, I would suggest zero for both DIC and TA. For the high end, my point was only to catch those gross errors where people used the wrong units, e.g., mmol/kg or umol/kg instead of mol/kg. For that objective, perhaps you could just position the high limit midway between 3000e-6 and 3000e-3.

@jamesorr
Copy link
Collaborator

I meant about half way between 3000e-6 and 3000e-3 on a log scale, i.e.,

3000e-(4.5) = 0.095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants