Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable markdown links #655

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

stereobooster
Copy link
Contributor

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 95f0423
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/6535b67ea0e53b0008a409e8
😎 Deploy Preview https://deploy-preview-655--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

I don't see any harm in making this change. It adds functionality while maintaining the existing workflow. I only note that you have omitted the rel="noreferrer noopener" part of the link and I believe this is still required? It was added in #446 but potentially this is no longer necessary?

@jpanther jpanther added the enhancement New feature or request label Oct 22, 2023
@stereobooster
Copy link
Contributor Author

Anchor target=_blank implies rel=noopener by default (as of 2021, for most browsers). But not noreferrer. So yes, I need to fix this bit

@jpanther
Copy link
Owner

Thanks for amending it, I'll merge this one in now.

@jpanther jpanther merged commit 92eb1f6 into jpanther:dev Oct 24, 2023
5 checks passed
@stereobooster stereobooster deleted the portable-links branch October 24, 2023 07:05
@jpanther jpanther mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants