Replies: 1 comment 1 reply
-
I don't mind a single PR, or split into smaller ones, but I would say this... smaller PRs are much easier for me to test and generally get approved quicker than larger ones. However, if there's a bunch of code that's shared across the same feature, then putting it all together is helpful. So there's no set rule.. just what makes sense for that particular change. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I was going to take a stab at implementing SVG support for images. For example, in logo.html:
feels like it aught work for the logo component.
I can submit distinct PRs per thing, or try to do them all in one... is there a preference?
Beta Was this translation helpful? Give feedback.
All reactions