-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable inclusion for relationship object #159
Comments
I think this is supported (although maybe not in the way you expect):
I think there are tests that verify this behavior. I think that when the user sets |
I cannot verify that behaviour. At least for case 3 it seems I get |
Sorry, the last paragraph refers to how I think it should work. I can see now that I was not entirely clear 😄 |
Ah :) Trying to fix that I find that it's a problem that a |
FYI will continue to try to find the easiest way to fix no 3. |
I think I've found a fix for no 3 in #161 but it's currently failing the test case "Handles recursive properties on resource objects" where I'm not sure if the old behaviour should/need to be reproduced as is by making the check recursive. |
Looked at the test case "Handles recursive properties on resource objects" again and can't make sense of it really, at least in the context of how it relates to resource inclusion. :( @joukevandermaas can you shed some light? |
With #161 this issue is no longer relevant, at least for me, so I will close it. |
As described by http://jsonapi.org/format/#document-resource-object-relationships a "relationship object" MUST contain at least one of
links
,data
ormeta
. When desired to lazy load related data it makes sense to only include thelinks
key and omitdata
. This does not appear current possible with Saule so I propose to make that configurable.Somewhat related to #121.
The text was updated successfully, but these errors were encountered: