Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kong dependency to latest version #271

Closed
jotaen opened this issue Oct 6, 2023 · 2 comments
Closed

Upgrade kong dependency to latest version #271

jotaen opened this issue Oct 6, 2023 · 2 comments

Comments

@jotaen
Copy link
Owner

jotaen commented Oct 6, 2023 •
edited
Loading

klog still uses kong v0.7.1, although the latest version is v0.8.0 (at time of this writing).

After v0.7.1, there was a change in how kong handles errors from bindings. Errors, which are returned from bound objects, are now rewritten / reformatted, so the original error object is lost.

klog relies on the kong binding functionality in order to prettify AppError’s when something went wrong when executing a command. With the change in kong, the AppError object cannot be restored anymore.

I’m not sure yet how this can be fixed – options:

  • Changing how the context is bound within klog, i.e. using a different mechanism for the setup.
  • Submit a patch to kong, to avoid it rewriting the error
@jotaen jotaen mentioned this issue Oct 6, 2023
Merged
jotaen added a commit that referenced this issue Oct 6, 2023
@jotaen
Downgrade kong, to restore error handling/printing
80a8608 
Due to #271, kong has to be
downgraded again to v0.7.1.

This PR also adds tests that would uncover the problem.
@jotaen jotaen changed the title Upgrade kong to latest version Upgrade kong dependency to latest version Oct 6, 2023
@jotaen
Copy link
Owner Author

jotaen commented Oct 6, 2023

alecthomas/kong#383

@jotaen
Copy link
Owner Author

jotaen commented Oct 7, 2023

A fix has landed. Waiting for next kong release to bump dependency.

@jotaen jotaen closed this as completed in 0b9d589 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jotaen