Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce feature drag and pointer events handling #162

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: introduce feature drag and pointer events handling #162

wants to merge 14 commits into from
+1,514 −370

Conversation

gabbopalma
Copy link
Contributor

@gabbopalma gabbopalma commented Dec 4, 2024 •
edited
Loading

Closes #151 issue.

Important

This PR doesn't introduce the implementation of drag gestures on Web or iOS platforms.

@gabbopalma gabbopalma marked this pull request as draft December 4, 2024 16:32
gabbopalma and others added 9 commits December 4, 2024 18:51
@gabbopalma
chore: ktlint runned
e0bab73
@gabbopalma
Merge branch 'main' into feat/introduce-feature-drag-events
fb57d94
@gabbopalma
refactor: layer classes now have a list of Feature instead of Geometr…
f0252a4 
…y. Added generateFeatureList for geometry handling in examples.
@gabbopalma
feat: add queryRenderedFeatures method and related options for featur…
56c6241 
…e querying. Started call of pointer and featureDrag events.
@gabbopalma
Merge remote-tracking branch 'origin/main' into feat/introduce-featur…
0b85df4 
…e-drag-events
@gabbopalma
feat: updated pointer events handling to long press gestures and refa…
74581f3 
…ctor related code.
@gabbopalma
Merge remote-tracking branch 'origin/main' into feat/introduce-featur…
2b2a21e 
…e-drag-events
@gabbopalma
fix: update filter and layers types to JSArray for type safety in int…
ace0dac 
…erop
@gabbopalma
Merge remote-tracking branch 'origin/main' into feat/introduce-featur…
cbf03d7 
…e-drag-events
@rmmlopes
Copy link

rmmlopes commented Jan 5, 2025

Hi, I'm working on a project that needs to update polygons on the map. This PR would make that possible.

Any idea when it will be merged in?

@gabbopalma
Copy link
Contributor Author

Hi, I'm working on a project that needs to update polygons on the map. This PR would make that possible.

Any idea when it will be merged in?

Hi. I have currently stopped work because of the Christmas holidays. From January 7 I will resume work on this PR. I am close to the end of the work

@rmmlopes
Copy link

rmmlopes commented Jan 6, 2025

Hi, I'm working on a project that needs to update polygons on the map. This PR would make that possible.
Any idea when it will be merged in?

Hi. I have currently stopped work because of the Christmas holidays. From January 7 I will resume work on this PR. I am close to the end of the work

Awesome! Thanks!

@gabbopalma
Copy link
Contributor Author

gabbopalma commented Jan 10, 2025 •
edited
Loading

I decided not to introduce the Web implementation in the current PR.
The equality problems encountered in switching from GeometryCollection to FeatureCollection have been solved.
Currently I can't solve ktlint quality control, I kindly ask @josxha if he can perform it for me.

Implementation of a new way of handling gestures and, consequently, iOS and Web support will follow in a future PR.
At the moment, if @josxha approves it, I will introduce the “Android only works” warning in the code.

@gabbopalma gabbopalma marked this pull request as ready for review January 10, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
maplibre dev
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Provide a way to handle feature tap and drag events
2 participants
@gabbopalma @rmmlopes