Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greg's Wade Reloaded #56

Open
pawl opened this issue Mar 23, 2012 · 2 comments
Open

Greg's Wade Reloaded #56

pawl opened this issue Mar 23, 2012 · 2 comments

Comments

@pawl
Copy link
Contributor

pawl commented Mar 23, 2012

I think it's time to merge the Greg's Wade Reloaded into the Prusa to fix a few issues.

http://www.thingiverse.com/thing:18379

Prusa mentioned a few issues with the current STL's for the greg's extruder parts 2 months ago: https://github.com/prusajr/PrusaMendel/blob/master/CologneCourseNotes.txt

Merging the reloaded version should fix parts of both of these issues:
https://github.com/prusajr/PrusaMendel/issues/34
https://github.com/prusajr/PrusaMendel/issues/39

@jglauche
Copy link
Collaborator

First, I do not like to merge stuff from Thingiverse. I have done it before and I don't like it because it's tons of work. Put it on github if you want stuff merged.
Second, the site on Thingiverse states "Attribution - Creative Commons license." If that is a derivative of the Prusa Mendel one, it's a license infringement. If not, I still cannot merge it into GPLv3 code.
I noticed that when people put stuff on Thingiverse, they often do this without noticing/knowing that they're doing so. Please talk to them if you want that stuff mergeable.
Third, I'm not going to merge Herringbone Gears into master. There is place for that in restructure branch, but not as default. The default Prusa Mendel distribution should be as easy to print as possible.

@pawl
Copy link
Contributor Author

pawl commented Mar 31, 2012

There may actually not be much to gain from the Greg's Wade Reloaded. The issue with the nut trap size on the extruder body and on the large gear have been fixed in the restructure branch already. I think those changes really need to be merged with the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants