fix: #3267 implicit multiplication with a negative number and unit in

josdejong · Sep 18, 2024 · fb76ac4 · fb76ac4
1 parent 2a4faaa
commit fb76ac4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -10,6 +10,7 @@
   types (#3257). Thanks @smith120bh.
 - Fix: #3259 function `symbolicEqual` missing in the TypeScript definitions.
 - Fix: #3246 function `leafCount` missing in the TypeScript definitions.
+- Fix: #3267 implicit multiplication with a negative number and unit `in`.
 - Docs: fix broken links on the Configuration page. Thanks @vassudanagunta.
 
 # 2024-08-27, 13.1.1

diff --git a/src/expression/parse.js b/src/expression/parse.js
@@ -1074,6 +1074,7 @@ export const createParse = /* #__PURE__ */ factory(name, dependencies, ({
     while (true) {
       if ((state.tokenType === TOKENTYPE.SYMBOL) ||
           (state.token === 'in' && isConstantNode(node)) ||
+          (state.token === 'in' && isOperatorNode(node) && node.fn === 'unaryMinus' && isConstantNode(node.args[0])) ||
           (state.tokenType === TOKENTYPE.NUMBER &&
               !isConstantNode(last) &&
               (!isOperatorNode(last) || last.op === '!')) ||

diff --git a/test/unit-tests/expression/parse.test.js b/test/unit-tests/expression/parse.test.js
@@ -591,6 +591,11 @@ describe('parse', function () {
       approxDeepEqual(parseAndEval('(2+3) in'), new Unit(5, 'in'))
       approxDeepEqual(parseAndEval('a in', { a: 5 }), new Unit(5, 'in'))
       approxDeepEqual(parseAndEval('0.5in + 1.5in to cm'), new Unit(5.08, 'cm').to('cm'))
+
+      assert(parseAndEval('2 meter^2').toString(), '2 meter^2')
+      assert(parseAndEval('-2 meter^2').toString(), '-2 meter^2')
+      assert(parseAndEval('2 in^2').toString(), '2 in^2')
+      assert(parseAndEval('-2 in^2').toString(), '-2 in^2')
     })
   })