Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing MIMe headers with NewEmailFromReader #139

Open
tarmo-randma opened this issue Feb 16, 2021 · 2 comments · May be fixed by #140
Open

Missing MIMe headers with NewEmailFromReader #139

tarmo-randma opened this issue Feb 16, 2021 · 2 comments · May be fixed by #140

Comments

@tarmo-randma
Copy link
Contributor

In the latest master version (943e75f) when e-mails are created with NewEmailFromReader and they contain attachments, the attachments will have empty MIME headers. This is due to commit b84218f on Dec 30, 2020 which resolved a different issue. The MIME headers were never covered by a Unit test, so this was not picked up.

The old removed implementation however was also buggy as it set the Content-Id header of the attachment always to the file name. This is incorrect behavior as Content-Id can have a different value and should be read directly from the MIME header.
tarmo-randma pushed a commit to erply/email that referenced this issue Feb 16, 2021
jordan-wright#139 - Missing MIMe headers with NewEmailFromReader
b42033a
@tarmo-randma tarmo-randma linked a pull request Feb 16, 2021 that will close this issue
Open
@tarmo-randma
Copy link
Contributor Author

I have created PR #140 that will resolve this issue

@gonejack
Copy link

Hi, any release plan about this fix? My project https://github.com/gonejack/email-to-epub is effected by this bug currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for MIME headers when using NewEmailFromReader erply/email
2 participants
@gonejack @tarmo-randma