Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags and version #48

Open
fabaff opened this issue Jun 8, 2023 · 2 comments
Open

Tags and version #48

fabaff opened this issue Jun 8, 2023 · 2 comments
Labels
no-stale This issue or PR is exempted from the stable bot.

Comments

@fabaff
Copy link

fabaff commented Jun 8, 2023

Problem/Motivation

Tags contains no corresponding version entry in pyproject.toml, e.g., for v0.0.9 version = "0.0.0"

Expected behavior

Having a versioned setup when using the GitHub tags/releases.

Actual behavior

see above

Steps to reproduce

Clone the repo, choose a tag and install it.

Proposed changes

Add current version to pyproject.toml. This help users who are going for the GitHub releases and the distributions which needs to package it as it's a Home Assistant dependency.

@joostlek
Copy link
Owner

joostlek commented Jun 9, 2023

Hmm, I took the base setup from https://github.com/frenck/python-vehicle/blob/main/pyproject.toml and they have the same. I'll check if there's something that can be automated for this.

@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 11, 2023
@joostlek joostlek added no-stale This issue or PR is exempted from the stable bot. and removed stale There has not been activity on this issue or PR for quite some time. labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale This issue or PR is exempted from the stable bot.
Projects
None yet
Development

No branches or pull requests

2 participants