Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig.json with comments does not work (in particular, tsc --init) #21

Open
patarapolw opened this issue Jul 23, 2020 · 1 comment · May be fixed by #27
Open

tsconfig.json with comments does not work (in particular, tsc --init) #21

patarapolw opened this issue Jul 23, 2020 · 1 comment · May be fixed by #27

Comments

@patarapolw
Copy link

Actually, require(PATH_TO_TSCONFIG_JSON) will break, if tsconfig.json has comments. I didn't inserted the comments myself, but npx tsc --init did.

Not really sure how tsc internally read JSON with comments...
@0x80
Copy link

0x80 commented Jul 24, 2020

I ran into this issue as well. It's really helpful that Typescript allows using comments in JSON files. Would be great if you can support this.

@pearagit pearagit linked a pull request Feb 20, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stripped comments from project file to support jsonc pearagit/tscpaths
2 participants
@0x80 @patarapolw