Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak: preferences dialog not active, plugin dead? #241

Closed
leamas opened this issue Jan 14, 2022 · 11 comments
Closed

Flatpak: preferences dialog not active, plugin dead? #241

leamas opened this issue Jan 14, 2022 · 11 comments

Comments

@leamas
Copy link

leamas commented Jan 14, 2022

As heading says. After installing and activating the plugin, the preferences dialog does not become active.

This is actually about a large number of plugins, see OpenCPN/plugins#578. Will only file this one for testplugin plugins.

@jongough
Copy link
Owner

Testplugin does not use preferences and does not include that in the list of items in the Init function. So working as expected.

@jongough
Copy link
Owner

Can this be closed as it is not relevant to Testplugin as it has no preferences page?

@leamas
Copy link
Author

leamas commented Jan 23, 2022

Yes, if none of other plugins listed in OpenCPN/plugins#578 are using the testplugin templates.

@jongough
Copy link
Owner

This is not a template issue. If you don't have the requisite setup in the plugin code you will not get the preferences.There is nothing in the build process that would stop it working. If there was none of the setup information in the Init process would work.

@rgleason
Copy link
Contributor

I have put this information and a link in the TP Plugins Issue here
#177

So this can be closed, but it is not fixed!!

@leamas
Copy link
Author

leamas commented Jan 24, 2022

Well, if this bug depends on #177, which it seems, it should not be closed as long as #177 is open.

OTOH, looking at #177 it seems unlikely it will be closed at some defined point.

@jongough: your call. Not important for me.

@jongough
Copy link
Owner

I have just run ODraw 1.8.13.0 from the alpha repository in flatpak on ubuntu 20.04, this fails to load due to:

15:45:02.397 MESSAGE pluginmanager.cpp:2232 PlugInManager: Loading PlugIn: /home/jon/.var/app/org.opencpn.OpenCPN/lib/opencpn/libocpn_draw_pi.so
15:45:02.397   ERROR dlunix.cpp:162 libwx_baseu-3.1.so.5: cannot open shared object file: No such file or directory
15:45:02.397 MESSAGE pluginmanager.cpp:2291    PlugInManager: Cannot load library: /home/jon/.var/app/org.opencpn.OpenCPN/lib/opencpn/libocpn_draw_pi.so 

If I load OD 1.8.12.0 is loads OK. There is only one difference for the flatpak build is the working one was built 27 days ago, the non-working one was built yesterday. github required that https be used instead of git.

The link of the flatpak module is the same:
1.8.12.0:

/usr/bin/c++ -fPIC -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection  -fPIC -DFLATPAK -pthread -D__WXGTK3__ -O3 -DNDEBUG  -Wl,-Bsymbolic -shared -Wl,-soname,libocpn_draw_pi.so -o libocpn_draw_pi.so CMakeFiles/ocpn_draw_pi.dir/src/Boundary.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryCSVImport.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryPoint.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryPointCSVImport.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/DR.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/DRProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/EBL.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/EBLProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/GZ.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/GZMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/GZProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ocpn_draw_pi.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODAPI.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODConfig.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODdc.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODDRDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODDRDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODEventHandler.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODicons.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODIconCombo.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODJSON.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODLayer.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODLinkPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODLinkPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODMarkIcon.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODNavObjectChanges.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODNewODPointDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODNewODPointDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPath.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPathPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPathPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPoint.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPointPropertiesDialog.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPointPropertiesImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPositionParser.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODRolloverWin.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODSelect.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODShaders.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODToolbarDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODToolbarImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODUtils.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PathMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PathAndPointManagerDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PathAndPointManagerDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PIL.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PILProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PILPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PILPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PointMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/TextPoint.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/TextPointCSVImport.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPlatform.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/bbox.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/cutil.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/geodesic.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/georef.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/Hyperlink.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/SelectItem.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/TexFont.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/clipper.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/pugixml.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-schema-draft7.json.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-uri.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-validator.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-patch.cpp.o CMakeFiles/ocpn_draw_pi.dir/libs/wxJSON/src/jsonreader.cpp.o CMakeFiles/ocpn_draw_pi.dir/libs/wxJSON/src/jsonval.cpp.o CMakeFiles/ocpn_draw_pi.dir/libs/wxJSON/src/jsonwriter.cpp.o  lib/libGLU.a libs/gdal/libGDAL.a libs/tinyxml/libTINYXML.a -L/app/lib -pthread -lwx_baseu-3.0 -lwx_gtk3u_core-3.0 -lwx_baseu_net-3.0 -lwx_baseu_xml-3.0 -lwx_gtk3u_html-3.0 -lwx_gtk3u_adv-3.0 -lwx_gtk3u_aui-3.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lbz2 -lz 
 Running post build action on libocpn_draw_pi.so.

1.8.13.0:

/usr/bin/c++ -fPIC -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection  -fPIC -DFLATPAK -pthread -D__WXGTK3__ -O3 -DNDEBUG  -Wl,-Bsymbolic -shared -Wl,-soname,libocpn_draw_pi.so -o libocpn_draw_pi.so CMakeFiles/ocpn_draw_pi.dir/src/Boundary.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryCSVImport.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryPoint.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/BoundaryPointCSVImport.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/DR.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/DRProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/EBL.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/EBLProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/GZ.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/GZMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/GZProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ocpn_draw_pi.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODAPI.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODConfig.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODdc.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODDRDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODDRDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODEventHandler.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODicons.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODIconCombo.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODJSON.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODLayer.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODLinkPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODLinkPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODMarkIcon.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODNavObjectChanges.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODNewODPointDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODNewODPointDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPath.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPathPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPathPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPoint.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPointPropertiesDialog.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPointPropertiesImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPositionParser.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODRolloverWin.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODSelect.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODShaders.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODToolbarDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODToolbarImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODUtils.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PathMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PathAndPointManagerDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PathAndPointManagerDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PIL.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PILProp.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PILPropertiesDialogDef.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PILPropertiesDialogImpl.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/PointMan.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/TextPoint.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/TextPointCSVImport.cpp.o CMakeFiles/ocpn_draw_pi.dir/src/ODPlatform.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/bbox.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/cutil.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/geodesic.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/georef.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/Hyperlink.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/SelectItem.cpp.o CMakeFiles/ocpn_draw_pi.dir/ocpnsrc/TexFont.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/clipper.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/pugixml.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-schema-draft7.json.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-uri.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-validator.cpp.o CMakeFiles/ocpn_draw_pi.dir/extsrc/json-schema-validator/json-patch.cpp.o CMakeFiles/ocpn_draw_pi.dir/libs/wxJSON/src/jsonreader.cpp.o CMakeFiles/ocpn_draw_pi.dir/libs/wxJSON/src/jsonval.cpp.o CMakeFiles/ocpn_draw_pi.dir/libs/wxJSON/src/jsonwriter.cpp.o  lib/libGLU.a libs/gdal/libGDAL.a libs/tinyxml/libTINYXML.a -L/app/lib -pthread -lwx_baseu-3.1 -lwx_gtk3u_core-3.1 -lwx_baseu_net-3.1 -lwx_baseu_xml-3.1 -lwx_gtk3u_html-3.1 -lwx_gtk3u_aui-3.1 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lbz2 -lz 

It would appear that the environment has been updated from wxWidgets 3.0 to wxWidgets 3.1.

@leamas
Copy link
Author

leamas commented Jan 26, 2022

It would appear that the environment has been updated from wxWidgets 3.0 to wxWidgets 3.1.

Sort of. The beta branch is updated to wx3.1 as announced here

However, builds should be done against the stable branch. See the shipdriver flatpak manifest for details.

@jongough
Copy link
Owner

I have just updated frontend2 to handle the change in wxWidgets for 20.08 and rebuilt ODraw. I have tried it on Ubuntu 20.04 with flatpak 20.08/stable and it all works including the preferences dialog. So it is not an issue with frontend2 that other plugins are not showing the preferences.

@rgleason
Copy link
Contributor

rgleason commented Apr 1, 2022

Can't this be closed now?

@rgleason
Copy link
Contributor

rgleason commented Apr 22, 2022

@jongough @leamas This is a very old post, it is generic and offers no specific insight into the issue and is unactionable. It is therefore appropriate to close it. Jon if Alec does not close this, please close. I cannot. Furthermore I believe it was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants