Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on startup of OCPN Draw 1.8.52.0 with OpenCPN 5.10.2-0 #556

Open
gospo24 opened this issue Oct 12, 2024 · 32 comments
Open

crash on startup of OCPN Draw 1.8.52.0 with OpenCPN 5.10.2-0 #556

gospo24 opened this issue Oct 12, 2024 · 32 comments

Comments

@gospo24
Copy link

gospo24 commented Oct 12, 2024

Hi there,
OpenCPN 5.10.2-0 with OCPN Draw 1.8.46 is working properly (PC with OCPN Draw not updated to 1.8.52.0).

2nd PC: OpenCPN 5.10.2-0 with OCPN Draw updated to 1.8.52.0 crashes on launch. Deleting OCPN Draw 1.8.52.0 (with all plugins deactivated on launching) "resolves" the issue: no crash, but also no OCPN Draw available :-(

Any ideas? Many thanks
gospo23

crash_reports.zip

@jongough
Copy link
Owner

Can you please provide the OpenCPN.log file and the OpenCPN.conf/cfg file for the instance that is crashing. Also, what platform are you doing this on?

@gospo24
Copy link
Author

gospo24 commented Oct 12, 2024 via email

@gospo24
Copy link
Author

gospo24 commented Oct 13, 2024

Hi,
the crash already occours when installing OCPN Draw 1.8.52.0 via the plug-in manager of OpenCPN.
System here is Windows 11, version 23H2 - with all quality updates to date.
On crahsing, OpenCPN displays a small window saying "Collecting information about the problem" and listing several lines "Dumping info for thread #####". Hope this helps, thank you.

gospo24

opencpn.zip

@nocheinpeter
Copy link

nocheinpeter commented Oct 13, 2024

openCPN 5.10.2 crashes on Android 14 also then try to show the plugin tab, the plugin OCPN Draw 1.8.52.0 is just installed and not actived. No chance to remove it; must wipe all data of the app to bring it back to work. Galaxy Tab A7 lite.
See Link

OCPN Draw 1.8.48.0 did work on openCPN 5.8.2.

Regards
Peter

@jongough
Copy link
Owner

It would appear that you are using a locale of de_DE. Would you mind changing to en_US and see if OCPN Draw still crashes? I have it installed now on a Win 11 machine with en_US and it is working fine. I did fix a problem when the language was changed from en_US to anything else when OCPN was running due to the icons being double loaded. I thought I had fixed that.

I have switched languages on my test system and it seems to work OK. Was this a clean install of OCPN Draw or an upgrade?

@jongough
Copy link
Owner

openCPN 5.10.2 crashes on Android 14 also then try to show the plugin tab, the plugin OCPN Draw 1.8.52.0 is just installed and not actived. No chance to remove it; must wipe all data of the app to bring it back to work. Galaxy Tab A7 lite. See Link

OCPN Draw 1.8.48.0 did work on openCPN 5.8.2.

Regards Peter

I am trying to identify what may be going wrong on the Win 11 system as that is easier to work with. If I find anything to fix I will put out a new version which will automatically be built for Android which you can then test to see if the problem is fixed there.

@jongough
Copy link
Owner

There was a crash in OCPN Draw when changing languages which 1.8.52 fixes. I installed 1.8.46 and changed language and OCPN crashed. It did restart OK. I then updated to 1.8.52 and could change languages without problems. There was a work around for the crash which was to disable OCPN Draw, restart OCPN, change language, then re-enable OCPN Draw. This seemed to work for the person who reported it.

@gospo24
Copy link
Author

gospo24 commented Oct 14, 2024 via email

@StefLedof
Copy link

Hello,
OCPN 5.10.2 crashe since ODRAW 1.8.50 with locale fr_FR. Workaround ( change locale to en_US ) don't work for my computer ;-(
ODRAW 1.8.49.1 is ok.
Many thanks
Stéphane

@jongough
Copy link
Owner

jongough commented Oct 14, 2024

The work around is to disable, and uninstall the older version of OD. Restart OCPN and re-install OD. That should work.

It is changing the language that causes the issue not the language itself. The reason I am asking for en_US to be used is that is the default language for OCPN and may help to narrow down the crash location.

@gospo24
Copy link
Author

gospo24 commented Oct 19, 2024

Hi Jon,
sorry for the delay regarding my response to your comments and efforts. Unfortunately, the problem seems to persist despite respecting your recommended procedure. So, even with the EN front end, after deleting and reinstalling ODraw OpenCPN still crashes here. To me it seems that OpenCPN already crashes (with EN front end) when INSTALLING OCPN Draw 1.8.46 - so, not after installation when trying to "use" it. Could it be that this is caused by the German Windows system I am using? Thanks for coming back.
P.S.: Fortunately, I did not update ODraw on my boat laptop - since we are on a trip by the end of next week!
BR
Gospo24

@bdbcat
Copy link
Contributor

bdbcat commented Oct 21, 2024

All...
We now have a new version of ocpn-draw_pi in the plugin master catalog. It is Version 1.8.55.
Please take a look.

Thanks
Dave & Jon

@StefLedof
Copy link

Hello, sorry but OD 1.8.55 crash on my computer ( trying upgrade OD, fresh install, ...).
Stéphane
b5340459-1fe0-4fb0-be1d-0179327cf80d.zip

@nocheinpeter
Copy link

openCPN crashes after install of OD 1.8.55. Windows 10, German language.

16:59:49.329 MESSAGE plugin_loader.cpp:442 Checking plugin candidate: C:\Users\sturm\AppData\Local\opencpn\plugins\o-charts_pi.dll
16:59:49.329 MESSAGE plugin_loader.cpp:442 Checking plugin candidate: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi.dll
16:59:49.329 MESSAGE plugin_loader.cpp:508 Checking plugin compatibility: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi.dll
16:59:49.331 MESSAGE plugin_loader.cpp:1231 Compatible wxWidgets plugin library found for C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi.dll: wxmsw32u_core_vc14x.dll
16:59:49.331 MESSAGE plugin_loader.cpp:1374 Plugin is compatible: true
16:59:49.331 MESSAGE plugin_loader.cpp:1390 PluginLoader: Loading PlugIn: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi.dll
16:59:49.349 MESSAGE ODicons.cpp:41 ocpn_draw_pi ToolBarIconRefSize: 0
16:59:49.349 MESSAGE base_platform.cpp:273 PlugInManager: Using data dirs from: C:\Users\sturm\AppData\Local\opencpn\plugins;C:\Program Files (x86)\OpenCPN\plugins
16:59:49.350 MESSAGE base_platform.cpp:285 PlugInManager: using data dir: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi
16:59:49.350 MESSAGE ODicons.cpp:52 ocpn_draw_pi data location: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\
16:59:49.350 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\ODManager_Properties_MUI.svg,  width: 0, height: 0
16:59:49.357 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\ODManager_MUI.svg,  width: 0, height: 0
16:59:49.362 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\ODManagergrey_MUI.svg,  width: 0, height: 0
16:59:49.365 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\boundary_MUI.svg,  width: 0, height: 0
16:59:49.370 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\boundarygrey_MUI.svg,  width: 0, height: 0
16:59:49.373 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\pointbutton_MUI.svg,  width: 0, height: 0
16:59:49.376 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\pointbuttongrey_MUI.svg,  width: 0, height: 0
16:59:49.379 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\textpointbutton_MUI.svg,  width: 0, height: 0
16:59:49.384 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\textpointbuttongrey_MUI.svg,  width: 0, height: 0
16:59:49.390 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\EBL_MUI.svg,  width: 0, height: 0
16:59:49.407 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\EBLgrey_MUI.svg,  width: 0, height: 0
16:59:49.424 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\DR_MUI.svg,  width: 0, height: 0
16:59:49.442 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\DRgrey_MUI.svg,  width: 0, height: 0
16:59:49.459 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\GZ_MUI.svg,  width: 0, height: 0
16:59:49.475 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\GZgrey_MUI.svg,  width: 0, height: 0
16:59:49.494 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\PIL_MUI.svg,  width: 0, height: 0
16:59:49.512 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\PILgrey_MUI.svg,  width: 0, height: 0
16:59:49.550 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\ODManager_MUI.svg,  width: 32, height: 32
16:59:49.553 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\ODManagergrey_MUI.svg,  width: 32, height: 32
16:59:49.556 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\boundary_MUI.svg,  width: 32, height: 32
16:59:49.559 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\boundarygrey_MUI.svg,  width: 32, height: 32
16:59:49.562 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\pointbutton_MUI.svg,  width: 32, height: 32
16:59:49.565 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\pointbuttongrey_MUI.svg,  width: 32, height: 32
16:59:49.568 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\textpointbutton_MUI.svg,  width: 32, height: 32
16:59:49.571 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\textpointbuttongrey_MUI.svg,  width: 32, height: 32
16:59:49.573 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\EBL_MUI.svg,  width: 32, height: 32
16:59:49.577 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\EBLgrey_MUI.svg,  width: 32, height: 32
16:59:49.582 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\DR_MUI.svg,  width: 32, height: 32
16:59:49.586 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\DRgrey_MUI.svg,  width: 32, height: 32
16:59:49.590 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\GZ_MUI.svg,  width: 32, height: 32
16:59:49.595 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\GZgrey_MUI.svg,  width: 32, height: 32
16:59:49.599 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\PIL_MUI.svg,  width: 32, height: 32
16:59:49.604 MESSAGE ODicons.cpp:301 ocpn_draw_pi LoadSVG: filename: C:\Users\sturm\AppData\Local\opencpn\plugins\ocpn_draw_pi\data\PILgrey_MUI.svg,  width: 32, height: 32
16:59:49.635 MESSAGE ODEventHandler.cpp:69 Finished constructor
16:59:49.663 MESSAGE ODConfig.cpp:248 Laden von Navobjects von C:\ProgramData\opencpn\plugins\ocpn_draw_pi\data\ODnavobj.xml
16:59:49.676 MESSAGE ODConfig.cpp:258 Done loading ODnavobjects
16:59:49.677 MESSAGE ocpn_draw_pi.cpp:765 Getting .gpx layer files from: C:\ProgramData\opencpn\plugins\ocpn_draw_pi\Layers\
16:59:49.677 MESSAGE ODConfig.cpp:333 New layer 1: Niedersachsen

I delete the old plugin data at C:\ProgramData\opencpn\plugins\ocpn_draw_pi and the restarted openCPN.
Now it works on Windows 10. I will try later with Android.

@nocheinpeter
Copy link

On Android 13 no more crashes. Can draw but cannot import previoulsy exported areas. On Windows the import worked.
Maybe a file system read issue? Tried from documents and download folders.

@bdbcat
Copy link
Contributor

bdbcat commented Oct 21, 2024

Peter...
Do you have a saved copy of old "C:\ProgramData\opencpn\plugins\ocpn_draw_pi"?
Maybe in trash bin?

Also, will you post a copy of the data you are trying to import to Android?
Thanks
Dave

@nocheinpeter
Copy link

Peter... Do you have a saved copy of old "C:\ProgramData\opencpn\plugins\ocpn_draw_pi"? Maybe in trash bin?

Also, will you post a copy of the data you are trying to import to Android? Thanks Dave

Dave, see attached zip files.

ocpn_draw_pi_windows.zip
odraw_import_android.zip

Regards
Peter

@jongough
Copy link
Owner

Hello, sorry but OD 1.8.55 crash on my computer ( trying upgrade OD, fresh install, ...). Stéphane b5340459-1fe0-4fb0-be1d-0179327cf80d.zip

What OS are you using and what version? Are you using en_US as the language or another language, if so which one. Did you disable OD, then click OK, then go back into settings and uninstall OD and click OK, then restart OCPN and install the new version? Seems a bit complicated but trying to understand the sequence you used and if there are any workarounds we can try?

@StefLedof
Copy link

StefLedof commented Oct 22, 2024

Hello,
W10 and W11, running the workaround above with locale fr_FR and en_US, OCPN crash when activating ODRAW
Thk
Stéphane

@bdbcat
Copy link
Contributor

bdbcat commented Oct 22, 2024

Jon...
On the crash on upgrade, I have reproduced it under linux.
Using the data set for Windows provided by Peter above, simply unzip and copy it into ~/.opencpn/plugins, replacing the current contents. Start OCPN with current OD enabled, and it will crash while loading the data set.
The crash is in the method: ODPath *ODNavObjectChanges::GPXLoadPath1(), and is a null pointer deref.

I hope that this is the root cause of the random upgrade problems we have seen.
Good Luck
Dave

@jongough
Copy link
Owner

Hello, W10 and W11, running the workaround above with locale fr_FR and en_US, OCPN crash when activating ODRAW Thk Stéphane

Do you OD layers? If so, can you rename the layers files i.e. change the extension from 'gpx' to 'gpx-save' and then restart OCPN. Can you please let me know the outcome?

1 similar comment
@jongough
Copy link
Owner

Hello, W10 and W11, running the workaround above with locale fr_FR and en_US, OCPN crash when activating ODRAW Thk Stéphane

Do you OD layers? If so, can you rename the layers files i.e. change the extension from 'gpx' to 'gpx-save' and then restart OCPN. Can you please let me know the outcome?

@jongough
Copy link
Owner

I think I have found the error to do with importing Layers. I am going to put up a new version, 1.8.56.0, and it should be available in the alpha and beta repositories.

@StefLedof
Copy link

StefLedof commented Oct 23, 2024

Hello, W10 and W11, running the workaround above with locale fr_FR and en_US, OCPN crash when activating ODRAW Thk Stéphane

Do you OD layers? If so, can you rename the layers files i.e. change the extension from 'gpx' to 'gpx-save' and then restart OCPN. Can you please let me know the outcome?
Hello,
Yes I do OD layers. Without OCPN don't crash.
Stéphane

@bdbcat
Copy link
Contributor

bdbcat commented Oct 23, 2024

Version 1.8.56.0 now in Alpha and Beta repos.

@StefLedof
Copy link

Version 1.8.56.0 now in Alpha and Beta repos.

Hello, work fine !
Thank
Stéphane

@jongough
Copy link
Owner

There is a new fix in prod for OD and crashes when importing layers. This is 1.8.56.0 .

@nocheinpeter
Copy link

I can confirm that the pi v1.8.56.0 is no longer crashing when importing/using the layer "Niedersachsen.gpx" provided above.
Tested with Windows 10 / locale DE.

On Android import/export is still not possible, probably due to the changed interface to access the file system? Maybe @bdbcat knows more, other plugins VDR had same issue. Also route import/export.

Regards
Peter

@bdbcat
Copy link
Contributor

bdbcat commented Oct 24, 2024

Peter...
I confirm the import trouble on Android. You are correct that it exactly follows the VDR_pi model. I will do the same for ODraw, and submit a PR to Jon soon. Please stand by.

@bdbcat
Copy link
Contributor

bdbcat commented Oct 25, 2024

Peter...
Unfortunately, the solution to file import on ODraw will require an update to core Android version to properly support A10+.
You may expect this in a few days as I gather other pending changes to one release.
Thanks for your patience.

@nocheinpeter
Copy link

Dave, thank you. For me it is not time critical. In Germany is winter season, boat on land till April...

@gospo24
Copy link
Author

gospo24 commented Oct 25, 2024

Hi Jon,
many thanks for your efforts. With OD 1.8.56.0 things seem to be resolved. For both, English and German front-end.
I had/have also layers being used. So, everything is fine again.
Best regards
gospo24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants