Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you! #1

Closed
EugenMayer opened this issue Nov 22, 2024 · 2 comments
Closed

Thank you! #1

EugenMayer opened this issue Nov 22, 2024 · 2 comments

Comments

@EugenMayer
Copy link

thank you for taking up the work to continue. I asked for an answer about the project status of 'Ecwid/consul-api' inhttps://github.com/Ecwid/issues/249

Are you going to maintain the consul-api a little further - are you interested in others helping so a possible successor could be created?

@jon5477
Copy link
Owner

jon5477 commented Nov 24, 2024

No problem. I saw the original repository has not addressed a lot of issues and since I use this in production these issues need to be resolved. I welcome contributors if they are interested in helping to maintain this project.

@EugenMayer
Copy link
Author

EugenMayer commented Nov 24, 2024

Well to similar reasons, i'am interested in keeping the package maintained. I do not have big "feature" goals at all. More or less my goal would be

  1. keep the libraries production ready (CVEs, deprecations), good example is the removal of httpclient4 (which you alread did)
  2. Ensure we stay with the non-deprecated APIs of consul (which you already did, 1.18)
  3. Keep the exposed SDK/Interface sane

The list is ordered in the way i would put time into the project. So if those goals can be aligned with your ideas, i would be happy to jump on the ship.

I created some PRs to ensure we run tests every commit PR (to avoid what happened just now, the test did not run anymore since you introduced filter), and fixed the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants