OV2640: Brightness, contrast + saturation not working anymore

[Slider0007]

The Problem

OV2640: Brightness, contrast and saturation parameter are not functional anymore.

This workaround to enable functionality is somewhere lost between 15.7 and 16.0:

AI-on-the-edge-device/code/components/jomjol_controlcamera/ClassControllCamera.cpp

Line 218 in 0d0b018

/* Workaround - bug in cam library - enable bits are set without using bitwise OR logic -> only latest enable setting is used */

Workaround is still required for OV2640 camera even with newest camera driver.
For OV5640 it's not required, it's functional without this workaround.

Version

16.0.0RC4

Logfile

n.a.

Expected Behavior

No response

Screenshots

No response

Additional Context

No response

[Slider0007]

@SybexX: FYI

[caco3]

@SybexX or @Slider0007 Does one of you have such HW and can add and test a fix?

[SybexX]

Please test whether this fixes the problem (no changes are necessary for the OV5640): https://github.com/SybexX/AI-on-the-edge-device/actions/runs/12131765400

[Slider0007]

Using the provided test firmware, brightness, contrast and saturation adaption is working again with OV2640.

Be ware: I've only tested the part which is related to this issue and not the additional changes which are also included in this branch. (I'm not sure if this branch is intended to be merged directly or split up again to only address this issue here. IMHO it usually doesn't make sense to test a branch which contains multiple topics.)