Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeable Port #2707

Open
JxxIT opened this issue Nov 18, 2023 · 11 comments
Open

Changeable Port #2707

JxxIT opened this issue Nov 18, 2023 · 11 comments
Labels
enhancement New feature or request won't do Out of scope for this project

Comments

@JxxIT
Copy link

JxxIT commented Nov 18, 2023

The Feature

First off, thanks for this amazing tool!

This feature adds a expert setting to change the port off the web interface. Working on a PR.

@JxxIT JxxIT added the enhancement New feature or request label Nov 18, 2023
@caco3 caco3 added the won't do Out of scope for this project label Aug 26, 2024
@caco3
Copy link
Collaborator

caco3 commented Aug 26, 2024

I think this is really expert feature and would cause a lot of trouble to normal users.
If you really need it, you easily con modify the firmware and build it yourself.

@JxxIT
Copy link
Author

JxxIT commented Aug 27, 2024

@caco3
Honestly, I completely forgot about this. 😄

In my case, I wanted to port forward both of my devices. My router doesn't have an option to change the change ports, so I had to change it manually.

I think this is really expert feature and would cause a lot of trouble to normal users.

Can you please explain why it is a expert feature and would cause a lot of trouble? I really missed this feature and I think a lot of users would like to see this.

@SybexX
Copy link
Collaborator

SybexX commented Aug 27, 2024

@JxxIT It wouldn't have helped you either, since the ESP couldn't connect and you couldn't access the website^^

@JxxIT
Copy link
Author

JxxIT commented Aug 27, 2024

@SybexX Do you mean by changing it directly in the source code? I did that, built, and it worked.

@SybexX
Copy link
Collaborator

SybexX commented Aug 27, 2024

shit written in the wrong issues^^

@caco3
Copy link
Collaborator

caco3 commented Aug 27, 2024

Can you please explain why it is a expert feature and would cause a lot of trouble? I really missed this feature and I think a lot of users would like to see this.

If it would be a user configurable option, a user, not understanding what he is doing, could change the port number and then lock himself out of the UI as he might not know how to add the port to the URL or forget the exotic number.

If you would want it, you could add a PR but it would have to be set in the wlan.ini file so users can not change it by accident.

@SybexX
Copy link
Collaborator

SybexX commented Aug 27, 2024

I don't know much about port forwarding, but isn't this done by the router/server?

@caco3
Copy link
Collaborator

caco3 commented Aug 27, 2024

Normally yes. Eg. the router can route the external port 12345 to the internal port 80 of a specific IP.
But some routers do not support port forwarding or do not allow to use different ports externally/internally.
But here I must say that it can not be an opensource's responsibility to work around a shitty router.
Get a better router or add a Raspberry Pi as reverse proxy which can do this.

@SybexX
Copy link
Collaborator

SybexX commented Aug 27, 2024

As far as I know, it's switched off on the Fritzbox because it's a security risk or something.

@caco3
Copy link
Collaborator

caco3 commented Aug 27, 2024

Yes, obviously it rips a hole into your network. You should only use it when understanding the impact.
The nowadays better approach is to VPN into your network and access it that way from outside.

@SybexX
Copy link
Collaborator

SybexX commented Aug 27, 2024

I use two Rpi's with iobroker + Adguard that handle everything and don't allow remote access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request won't do Out of scope for this project
Projects
None yet
Development

No branches or pull requests

3 participants