Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character Level Embedding #12

Open
KazutoshiShinoda opened this issue Sep 29, 2018 · 0 comments
Open

Character Level Embedding #12

KazutoshiShinoda opened this issue Sep 29, 2018 · 0 comments

Comments

@KazutoshiShinoda
Copy link

BiDAF/layers/char_embedding.py

Line 28 in 3e5ac9c

x = x.sum(2) # (N, seq_len, c_embd_size)

I feel strange to see this code.
Why do you sum over word_len dimension?
Why don't you apply 1D filter over word_len dimension?

Thank you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KazutoshiShinoda