Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry integration #16

Closed
johnthagen opened this issue Dec 28, 2019 · 9 comments · Fixed by #91
Closed

Poetry integration #16

johnthagen opened this issue Dec 28, 2019 · 9 comments · Fixed by #91
Labels
enhancement New feature or request

Comments

@johnthagen
Copy link
Owner

Poetry recently went 1.0, and looks pretty good. It's inspired by really solid package managers like Cargo.

There are some tox related issues that looked a bit concerning.

Should continue to monitor it, and if it continues to gain market share and maturity, consider switching from recommending pip-tools to poetry.

Related to #7

@johnthagen johnthagen added the enhancement New feature or request label Dec 28, 2019
@johnthagen

This comment has been minimized.

@johnthagen
Copy link
Owner Author

johnthagen commented Mar 28, 2020

@johnthagen

This comment has been minimized.

@johnthagen

This comment has been minimized.

@johnthagen

This comment has been minimized.

@johnthagen
Copy link
Owner Author

The latest tox configuration I have been trying with Poetry using tox-poetry-installer:

[tox]
envlist =
    fmt-check
    lint
    docs
    py{38,39}
skipsdist = true
skip_missing_interpreters = true
isolated_build = true
requires =
    tox-poetry-installer[poetry] == 0.8.1

[testenv]
require_locked_deps = true
install_project_deps = true
install_dev_deps = true
commands =
    {envpython} -m pytest --cov=fact --cov-report=html --cov-report=term {posargs}

[testenv:type-check]
install_project_deps = false
# Require all dev_deps to install types-* packages.
install_dev_deps = true
commands =
    mypy src tests

[testenv:lint]
install_project_deps = false
install_dev_deps = false
locked_deps =
    flake8
    pep8-naming
commands =
    flake8

[testenv:fmt]
install_project_deps = false
install_dev_deps = false
locked_deps =
    isort
    black
commands =
    isort .
    black .

[testenv:fmt-check]
install_project_deps = false
install_dev_deps = false
locked_deps =
    isort
    black
commands =
    isort --check-only .
    black --check .

@InCogNiTo124
Copy link

I'd like to chime in and say that poetry integration would be marvellous

@johnthagen johnthagen changed the title Consider poetry integration Poetry integration Oct 23, 2021
@johnthagen
Copy link
Owner Author

The export command can be used to work around the Poetry bootstrapping issue where a project is moved into a network where Poetry is challenging to install (but pip is bundled with Python).

@johnthagen
Copy link
Owner Author

Poetry 1.2 dependency groups look very promising. After 1.2 is released and the dust settles, investigate Poetry and PyCharm support for 1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants