From c87d1bf830797edead2fb883bdb2e8ebb79719eb Mon Sep 17 00:00:00 2001 From: Jonathan Gamble Date: Mon, 16 Dec 2024 15:43:33 -0600 Subject: [PATCH 1/7] remove socket test code --- app/UiEnv.scala | 1 - app/controllers/Dev.scala | 13 +----- app/views/base/page.scala | 8 ++-- conf/routes | 1 - modules/web/src/main/Env.scala | 5 -- modules/web/src/main/SocketTest.scala | 33 ------------- ui/common/src/socket.ts | 67 +-------------------------- 7 files changed, 7 insertions(+), 121 deletions(-) delete mode 100644 modules/web/src/main/SocketTest.scala diff --git a/app/UiEnv.scala b/app/UiEnv.scala index 5f15379a93e5..8a50ce369c80 100644 --- a/app/UiEnv.scala +++ b/app/UiEnv.scala @@ -25,7 +25,6 @@ object UiEnv def netConfig = env.net def contactEmailInClear = env.net.email.value def picfitUrl = env.memo.picfitUrl - def socketTest = env.web.socketTest given lila.core.config.NetDomain = env.net.domain given (using ctx: PageContext): Option[Nonce] = ctx.nonce diff --git a/app/controllers/Dev.scala b/app/controllers/Dev.scala index 4950c91c8e4c..adea16c0b1a4 100644 --- a/app/controllers/Dev.scala +++ b/app/controllers/Dev.scala @@ -27,7 +27,6 @@ final class Dev(env: Env) extends LilaController(env): env.web.settings.noDelaySecret, env.web.settings.prizeTournamentMakers, env.web.settings.sitewideCoepCredentiallessHeader, - env.web.socketTest.distributionSetting, env.tournament.reloadEndpointSetting, env.tutor.nbAnalysisSetting, env.tutor.parallelismSetting, @@ -80,14 +79,4 @@ final class Dev(env: Env) extends LilaController(env): env.mod.logApi.cli(command) >> env.api.cli(command.split(" ").toList) - def socketTestResult = AuthBody(parse.json) { ctx ?=> me ?=> - ctx.body.body - .validate[JsArray] - .fold( - err => BadRequest(Json.obj("error" -> err.toString)), - results => - env.web.socketTest - .put(Json.obj(me.userId.toString -> results)) - .inject(jsonOkResult) - ) - } +end Dev diff --git a/app/views/base/page.scala b/app/views/base/page.scala index ca9610d18bd5..916fd1142c5a 100644 --- a/app/views/base/page.scala +++ b/app/views/base/page.scala @@ -111,10 +111,10 @@ object page: dataDev, dataVapid := (ctx.isAuth && env.security.lilaCookie.isRememberMe(ctx.req)) .option(env.push.vapidPublicKey), - dataUser := ctx.userId, - dataSoundSet := pref.currentSoundSet.toString, - attr("data-socket-domains") := socketTest.socketEndpoints(netConfig).mkString(","), - attr("data-socket-test-running") := socketTest.isUserInTestBucket(), + dataUser := ctx.userId, + dataSoundSet := pref.currentSoundSet.toString, + attr("data-socket-domains") := (if ~pref.usingAltSocket then netConfig.socketAlts + else netConfig.socketDomains).mkString(","), dataAssetUrl, dataAssetVersion := assetVersion, dataNonce := ctx.nonce.ifTrue(sameAssetDomain).map(_.value), diff --git a/conf/routes b/conf/routes index 454a56b30c2b..0f9a6ffd0bff 100644 --- a/conf/routes +++ b/conf/routes @@ -879,7 +879,6 @@ GET /dev/settings controllers.Dev.settings POST /dev/settings/:id controllers.Dev.settingsPost(id) GET /prometheus-metrics/:key controllers.Main.prometheusMetrics(key: String) -POST /dev/socket-test controllers.Dev.socketTestResult # Push POST /mobile/register/:platform/:deviceId controllers.Push.mobileRegister(platform, deviceId) diff --git a/modules/web/src/main/Env.scala b/modules/web/src/main/Env.scala index 2b48d4ab3060..71d5e2212f9d 100644 --- a/modules/web/src/main/Env.scala +++ b/modules/web/src/main/Env.scala @@ -35,11 +35,6 @@ final class Env( if mode.isProd then scheduler.scheduleOnce(5 seconds)(influxEvent.start()) private lazy val pagerDuty = wire[PagerDuty] - val socketTest = SocketTest( - yoloDb(lila.core.config.CollName("socket_test")).failingSilently(), - settingStore - ) - lila.common.Bus.subscribeFun("announce"): case lila.core.socket.Announce(msg, date, _) if msg.contains("will restart") => pagerDuty.lilaRestart(date) diff --git a/modules/web/src/main/SocketTest.scala b/modules/web/src/main/SocketTest.scala deleted file mode 100644 index a7c1c82faf1c..000000000000 --- a/modules/web/src/main/SocketTest.scala +++ /dev/null @@ -1,33 +0,0 @@ -package lila.web - -import play.api.libs.json.* - -import lila.db.JSON -import lila.core.config.NetConfig -import lila.ui.Context - -final class SocketTest( - resultsDb: lila.db.AsyncCollFailingSilently, - settingStore: lila.memo.SettingStore.Builder -)(using Executor): - - val distributionSetting = settingStore[Int]( - "socketTestDistribution", - default = 0, - text = "Participates to socket test if userId.hashCode % distribution == 0".some - ) - - def put(results: JsObject) = resultsDb: coll => - coll.insert.one(JSON.bdoc(results)).void - - def isUserInTestBucket()(using ctx: Context) = - distributionSetting.get() > 0 && - ctx.pref.usingAltSocket.isEmpty && - ctx.userId.exists(_.value.hashCode % distributionSetting.get() == 0) - - def socketEndpoints(net: NetConfig)(using ctx: Context): List[String] = - ctx.pref.usingAltSocket.match - case Some(true) => net.socketAlts - case Some(false) => net.socketDomains - case _ if isUserInTestBucket() => net.socketDomains.head :: net.socketAlts.headOption.toList - case _ => net.socketDomains diff --git a/ui/common/src/socket.ts b/ui/common/src/socket.ts index a0f48eabd973..06eb0334e25b 100644 --- a/ui/common/src/socket.ts +++ b/ui/common/src/socket.ts @@ -1,7 +1,6 @@ import * as xhr from './xhr'; import { idleTimer, browserTaskQueueMonitor } from './timing'; import { storage, once, type LichessStorage } from './storage'; -import { objectStorage, nonEmptyStore, type ObjectStorage } from './objectStorage'; import { pubsub, type PubsubEvent } from './pubsub'; import { myUserId } from './common'; @@ -103,12 +102,6 @@ class WsSocket { private lastUrl?: string; private heartbeat = browserTaskQueueMonitor(1000); - private isTestRunning = document.body.dataset.socketTestRunning === 'true'; - private stats: { store?: ObjectStorage; m2: number; n: number; mean: number } = { - m2: 0, - n: 0, - mean: 0, - }; constructor( readonly url: string, @@ -136,8 +129,6 @@ class WsSocket { this.version = version; pubsub.on('socket.send', this.send); this.connect(); - this.flushStats(); - window.addEventListener('pagehide', () => this.storeStats({ event: 'pagehide' })); } sign = (s: string): void => { @@ -226,7 +217,6 @@ class WsSocket { private scheduleConnect = (delay: number = this.options.pongTimeout): void => { if (this.options.idle) delay = 10 * 1000 + Math.random() * 10 * 1000; - // debug('schedule connect ' + delay); clearTimeout(this.pingSchedule); clearTimeout(this.connectSchedule); this.connectSchedule = setTimeout(() => { @@ -275,7 +265,6 @@ class WsSocket { this.averageLag += mix * (currentLag - this.averageLag); pubsub.emit('socket.lag', this.averageLag); - this.updateStats(currentLag); }; private handle = (m: MsgIn): void => { @@ -313,7 +302,6 @@ class WsSocket { }; destroy = (): void => { - this.storeStats(); clearTimeout(this.pingSchedule); clearTimeout(this.connectSchedule); this.disconnect(); @@ -339,7 +327,6 @@ class WsSocket { pubsub.emit('socket.close'); if (this.heartbeat.wasSuspended) return this.onSuspended(); - this.storeStats({ event: 'close', code: e.code }); if (this.ws) { this.debug('Will autoreconnect in ' + this.options.autoReconnectDelay); @@ -374,7 +361,7 @@ class WsSocket { this.heartbeat.reset(); // not a networking error, just get our connection back clearTimeout(this.pingSchedule); clearTimeout(this.connectSchedule); - this.storeStats({ event: 'suspend' }).then(this.connect); + this.connect(); } private nextBaseUrl = (): string => { @@ -382,7 +369,7 @@ class WsSocket { if (!url || !this.baseUrls.includes(url)) { url = this.baseUrls[Math.floor(Math.random() * this.baseUrls.length)]; this.storage.set(url); - } else if (this.isTestRunning || this.tryOtherUrl) { + } else if (this.tryOtherUrl) { const i = this.baseUrls.findIndex(u => u === url); url = this.baseUrls[(i + 1) % this.baseUrls.length]; this.storage.set(url); @@ -393,56 +380,6 @@ class WsSocket { pingInterval = (): number => this.computePingDelay() + this.averageLag; getVersion = (): number | false => this.version; - - private async storeStats(event?: any) { - if (!this.lastUrl || !this.isTestRunning) return; - if (!event && this.stats.n < 2) return; - - const data = { - dns: this.lastUrl.includes(`//${this.baseUrls[0]}`) ? 'ovh' : 'cf', - n: this.stats.n, - ...event, - }; - if (this.stats.n > 0) data.mean = this.stats.mean; - if (this.stats.n > 1) data.stdev = Math.sqrt(this.stats.m2 / (this.stats.n - 1)); - this.stats.m2 = this.stats.n = this.stats.mean = 0; - - localStorage.setItem(`socket.test.${myUserId()}`, JSON.stringify(data)); - return this.flushStats(); - } - - private async flushStats() { - const dbInfo = { db: `socket.test.${myUserId()}--db`, store: `socket.test.${myUserId()}` }; - const last = localStorage.getItem(dbInfo.store); - - if (this.isTestRunning || last || (await nonEmptyStore(dbInfo))) { - try { - this.stats.store ??= await objectStorage(dbInfo); - if (last) await this.stats.store.put(await this.stats.store.count(), JSON.parse(last)); - - if (this.isTestRunning) return; - - const data = await this.stats.store.getMany(); - const rsp = await fetch('/dev/socket-test', { - method: 'POST', - body: JSON.stringify(data), - headers: { 'Content-Type': 'application/json' }, - }); - if (rsp.ok) window.indexedDB.deleteDatabase(dbInfo.db); - } finally { - localStorage.removeItem(dbInfo.store); - } - } - } - - private updateStats(lag: number) { - if (!this.isTestRunning) return; - - this.stats.n++; - const delta = lag - this.stats.mean; - this.stats.mean += delta / this.stats.n; - this.stats.m2 += delta * (lag - this.stats.mean); - } } class Ackable { From 1f652a9090ca5779e09b2eac90765b284f0e3bb2 Mon Sep 17 00:00:00 2001 From: Trevor Fitzgerald Date: Mon, 16 Dec 2024 21:31:43 -0500 Subject: [PATCH 2/7] recap: responsive tweaks for summary slide --- ui/recap/css/_recap.scss | 80 ++++++++++++++++++++++++++-------------- 1 file changed, 52 insertions(+), 28 deletions(-) diff --git a/ui/recap/css/_recap.scss b/ui/recap/css/_recap.scss index 44e3129a0094..96cdfa0ac2bc 100644 --- a/ui/recap/css/_recap.scss +++ b/ui/recap/css/_recap.scss @@ -159,31 +159,16 @@ body { } .recap__shareable { - .logo { - width: 60%; - max-width: 400px; - } + .logo, h2 { - font-size: 1.5em; - margin: 0.4em 0 1.5em; - } - .stat { - font-size: 1.5em; - @media (max-width: at-most($x-small)) { - font-size: 1.3em; - } - @media (max-width: at-most($xx-small)) { - font-size: 1.2em; - } + display: none; } .grid { display: flex; flex-wrap: wrap; - row-gap: 1.5em; - padding: 0.5em; + row-gap: 0.5em; .stat { - flex: 50%; a { border: none; @@ -195,32 +180,71 @@ body { } .openings { - margin-top: 2em; + margin-top: 1em; + display: flex; .stat { + flex: 50%; + font-size: 0.8em; margin-top: 1em; } } - @media (max-height: 650px) { +} + +@media screen and (orientation: portrait) { + .recap__shareable .grid .stat { + flex: 50%; + } +} +@media screen and (orientation: landscape) { + .recap__shareable .grid .stat { + flex: 33%; + } +} + +@media (min-height: at-least($short)) { + .recap__shareable { .logo { - height: 20px; - width: auto; + display: inline; + height: 30px; } h2 { - font-size: 1.2em; - margin: 0.4em 0; + display: block; + margin: 0.5em 0; + } + .grid { + row-gap: 1em; + padding: 0.5em; + } + } +} + +@media (min-width: at-least($x-small)) and (max-width: at-most($small)) and (min-height: at-least($tall)) and (max-width: at-most($x-tall)) { + .recap__shareable { + .logo { + height: 40px; + } + } +} + +@media (min-width: at-least($small)) and (max-width: at-most($large)), (min-height: at-least($x-tall)) { + .recap__shareable { + .logo { + height: 40px; } .openings { - margin-top: 1em; + margin-top: 2em; .stat { font-size: 1em; - margin-top: 0.5em; } } } - @media (min-width: at-least($xx-small)) { +} + +@media (min-width: at-least($large)) and (min-height: at-least($x-tall)) { + .recap__shareable { .logo { - display: none; + height: 80px; } } } From c223f73382b1af257e86bd4eef21777d7d96c639 Mon Sep 17 00:00:00 2001 From: Trevor Fitzgerald Date: Mon, 16 Dec 2024 21:36:48 -0500 Subject: [PATCH 3/7] recap: fix ".org" color on logo hover --- ui/recap/css/_recap.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/recap/css/_recap.scss b/ui/recap/css/_recap.scss index 44e3129a0094..6323f017a4b2 100644 --- a/ui/recap/css/_recap.scss +++ b/ui/recap/css/_recap.scss @@ -7,6 +7,7 @@ body { &, .site-title, .site-title span, + .site-title:hover span, .site-buttons .link { #user_tag::after, &, From 063b6732425be0c2b60e47374caa18dd835529e6 Mon Sep 17 00:00:00 2001 From: Jonathan Gamble <101470903+schlawg@users.noreply.github.com> Date: Mon, 16 Dec 2024 21:12:15 -0600 Subject: [PATCH 4/7] dont preventDefault on elements, fix #16609 --- ui/round/src/view/replay.ts | 39 ++++++++++++++++--------------------- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/ui/round/src/view/replay.ts b/ui/round/src/view/replay.ts index 4e05ed293ad3..957c3c5acfdc 100644 --- a/ui/round/src/view/replay.ts +++ b/ui/round/src/view/replay.ts @@ -146,28 +146,23 @@ const goThroughMoves = (ctrl: RoundController, e: Event) => { function renderButtons(ctrl: RoundController) { const firstPly = util.firstPly(ctrl.data), lastPly = util.lastPly(ctrl.data); - return h( - 'div.buttons', - { - hook: onInsert(bindMobileMousedown(e => goThroughMoves(ctrl, e))), - }, - [ - analysisButton(ctrl) || h('div.noop'), - ...[ - [licon.JumpFirst, firstPly], - [licon.JumpPrev, ctrl.ply - 1], - [licon.JumpNext, ctrl.ply + 1], - [licon.JumpLast, lastPly], - ].map((b: [string, number], i) => { - const enabled = ctrl.ply !== b[1] && b[1] >= firstPly && b[1] <= lastPly; - return h('button.fbt', { - class: { glowing: i === 3 && ctrl.isLate() }, - attrs: { disabled: !enabled, 'data-icon': b[0], 'data-ply': enabled ? b[1] : '-' }, - }); - }), - boardMenuToggleButton(ctrl.menu, i18n.site.menu), - ], - ); + return h('div.buttons', [ + analysisButton(ctrl) || h('div.noop'), + ...[ + [licon.JumpFirst, firstPly], + [licon.JumpPrev, ctrl.ply - 1], + [licon.JumpNext, ctrl.ply + 1], + [licon.JumpLast, lastPly], + ].map((b: [string, number], i) => { + const enabled = ctrl.ply !== b[1] && b[1] >= firstPly && b[1] <= lastPly; + return h('button.fbt.repeatable', { + class: { glowing: i === 3 && ctrl.isLate() }, + attrs: { disabled: !enabled, 'data-icon': b[0], 'data-ply': enabled ? b[1] : '-' }, + hook: onInsert(bindMobileMousedown(e => goThroughMoves(ctrl, e))), + }); + }), + boardMenuToggleButton(ctrl.menu, i18n.site.menu), + ]); } function initMessage(ctrl: RoundController) { From 654d7af6aea92959909169dfcd78455e558d6b31 Mon Sep 17 00:00:00 2001 From: yahya lafhal Date: Tue, 17 Dec 2024 04:28:22 +0000 Subject: [PATCH 5/7] Set the default opening explorer color to the player's played color --- ui/analyse/src/explorer/explorerConfig.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/analyse/src/explorer/explorerConfig.ts b/ui/analyse/src/explorer/explorerConfig.ts index 2c7c468bf0a1..72935df2c22e 100644 --- a/ui/analyse/src/explorer/explorerConfig.ts +++ b/ui/analyse/src/explorer/explorerConfig.ts @@ -83,7 +83,7 @@ export class ExplorerConfigCtrl { value: storedStringProp('analyse.explorer.player.name', this.myName || ''), previous: storedJsonProp('explorer.player.name.previous', () => []), }, - color: prevData?.color || prop('white'), + color: prevData?.color || prop(root.bottomColor()), byDb() { return this.byDbData[this.db()] || this.byDbData.lichess; }, From a11d4d814faa1a1407b0d3803e46f8bb2cf36938 Mon Sep 17 00:00:00 2001 From: Thibault Duplessis Date: Tue, 17 Dec 2024 09:34:46 +0100 Subject: [PATCH 6/7] double pool work queue size --- modules/pool/src/main/GameStarter.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/pool/src/main/GameStarter.scala b/modules/pool/src/main/GameStarter.scala index 0dd4acd22a26..ccf7399b1bbd 100644 --- a/modules/pool/src/main/GameStarter.scala +++ b/modules/pool/src/main/GameStarter.scala @@ -14,7 +14,7 @@ final private class GameStarter( )(using Executor, Scheduler): private val workQueue = scalalib.actor.AsyncActorSequencer( - maxSize = Max(32), + maxSize = Max(64), timeout = 10 seconds, name = "gameStarter", lila.log.asyncActorMonitor.full @@ -22,8 +22,8 @@ final private class GameStarter( def apply(pool: PoolConfig, couples: Vector[MatchMaking.Couple]): Funit = couples.nonEmpty.so: + val userIds = couples.flatMap(_.userIds) workQueue: - val userIds = couples.flatMap(_.userIds) for (perfs, ids) <- userApi.perfOf(userIds, pool.perfKey).zip(idGenerator.games(couples.size)) pairings <- couples.zip(ids).parallel(one(pool, perfs).tupled) From 9653123c3db76a0a1fa6b975d4fdded97a53fda2 Mon Sep 17 00:00:00 2001 From: Thibault Duplessis Date: Tue, 17 Dec 2024 09:41:55 +0100 Subject: [PATCH 7/7] send more recap notifs --- bin/mongodb/recap-notif.js | 111 +++++++++++++++++++------------------ 1 file changed, 58 insertions(+), 53 deletions(-) diff --git a/bin/mongodb/recap-notif.js b/bin/mongodb/recap-notif.js index bed89d613831..9fb2abcd6bc2 100644 --- a/bin/mongodb/recap-notif.js +++ b/bin/mongodb/recap-notif.js @@ -1,28 +1,44 @@ const year = 2024; const dry = false; -let count = 0; +let countAll = 0; +let countSent = 0; -const hasPuzzles = userId => db.user_perf.count({ _id: userId, 'puzzle.nb': { $gt: 0 } }); +print('Loading existing recaps...'); +const hasRecap = new Set(); +db.recap_report.find({}, { _id: 1 }).forEach(r => hasRecap.add(r._id)); +print('Loaded ' + hasRecap.size + ' recaps'); -function sendToUser(user) { - if (!user.enabled) { - print('------------- ' + user._id + ' is closed'); - return; - } - const exists = db.notify.countDocuments({ notifies: user._id, 'content.type': 'recap', }, { limit: 1 }); - if (exists) { - print('------------- ' + user._id + ' already sent'); - return; - } - if (user.seenAt < new Date('2024-01-01')) { - print('------------- ' + user._id + ' not seen in 2024'); - return; - } - if (!user.count?.game && !hasPuzzles(user._id)) { - print('------------- ' + user._id + ' no games or puzzles'); - return; +const hasPuzzles = userId => db.user_perf.countDocuments({ _id: userId, 'puzzle.nb': { $gt: 0 } }, { limit: 1 }); + +// only keeps users that don't yet have a recap notification for the year +// and don't have yet loaded their recap from another link +const filterNewUsers = users => { + const noRecap = users.filter(u => !hasRecap.has(u._id)); + const hasNotif = new Set(db.notify.distinct('notifies', { + notifies: { $in: noRecap.map(u => u._id) }, 'content.type': 'recap', 'content.year': year + })); + return noRecap.filter(u => !hasNotif.has(u._id)); +} + +function* group(size) { + let batch = []; + while (true) { + const element = yield; + if (!element) { + yield batch; + return; + } + batch.push(element); + if (batch.length >= size) { + let element = yield batch; + batch = [element]; + } } +}; + +function sendToUser(user) { + if (!user.count?.game && !hasPuzzles(user._id)) return; if (!dry) db.notify.insertOne({ _id: Math.random().toString(36).substring(2, 10), notifies: user._id, @@ -33,45 +49,34 @@ function sendToUser(user) { read: false, createdAt: new Date(), }); - count++; - print(count + ' ' + user._id); -} - -function sendToUserId(userId) { - const user = db.user4.findOne({ _id: userId }); - if (!user) { - print('------------- ' + userId + ' not found'); - return; - } - sendToUser(user); -} - -function sendToRoleOwners() { - db.user4.find({ enabled: true, roles: { $exists: 1, $ne: [] } }).forEach(user => { - roles = user.roles.filter(r => r != 'ROLE_COACH' && r != 'ROLE_TEACHER' && r != 'ROLE_VERIFIED' && r != 'ROLE_BETA'); - if (roles.length) { - sendTo(user); - } - }); -} - -function sendToTeamMembers(teamId) { - db.team_member.find({ team: teamId }, { user: 1, _id: 0 }).forEach(member => { - sendToUserId(member.user); - }); -} - -function sendToRandomOnlinePlayers() { - db.user4.find({ enabled: true, 'count.game': { $gt: 10 }, seenAt: { $gt: new Date(Date.now() - 1000 * 60 * 2) } }).sort({ seenAt: -1 }).limit(5_000).forEach(sendToUser); + countSent++; } function sendToRandomOfflinePlayers() { + const grouper = group(100); + grouper.next(); + const process = user => { + countAll++; + const batch = grouper.next(user).value; + if (batch) { + const newUsers = filterNewUsers(batch); + newUsers.forEach(sendToUser); + print('+ ' + newUsers.length + ' = ' + countSent + ' / ' + countAll); + sleep(20 * newUsers.length); + } + } db.user4.find({ - enabled: true, 'count.game': { $gt: 10 }, seenAt: { - $gt: new Date(Date.now() - 1000 * 60 * 60 * 24), - $lt: new Date(Date.now() - 1000 * 60 * 60) + enabled: true, + seenAt: { + // $gt: new Date('2024-01-01'), + $gt: new Date(Date.now() - 1000 * 60 * 60 * 24 * 2), + $lt: new Date(Date.now() - 1000 * 60 * 20) // avoid the lila notif cache! } - }).limit(25_000).forEach(sendToUser); + }).forEach(process); + process(); // flush the generator } sendToRandomOfflinePlayers(); + +print('Scan: ' + countAll); +print('Sent: ' + countSent);