Multiple fixes and improvements

[matheusmoreira]

The following pull requests have been merged and tested on hardware:

1. sunrise_sunset_face: Fix use of uninitialized memory. #329
2. Work around various silicon errata #340
3. USB Improvements #344
4. add compile-time options for all preferences to movement_config #295
5. moon_phase_face: Make alarm long-press reset to current day. #316
6. Advanced clock #373
   • With 24h only feature
7. Advanced pulsometer #371
8. Structured TOTP watch face #369
   • With code written by @maxz
     1. Allow for more TOTP credentials and enable cycling backwards through codes #356
9. Timeout event and sleep logic #376

The latest commits were fetched and merged, preserving authorship and date information. I also extensively credited all contributors in the merge commits.

[theAlexes]

Thanks for the thorough commenting and testing :) Once #373 is updated on this branch, we'll be happy to merge this.

[matheusmoreira]

Something I forgot to mention about this branch: the clock face replaces the simple clock face in it. I thought it was alright since I've been running it for weeks now with no issues, and I also tested alarms and hourly chimes too. I can split it up again if needed though.

[theAlexes]

@joeycastillo did request that the simple clock face remain in place, so i think restoring that will make this branch mergeable :)

[matheusmoreira]

Yes. More thorough testing of the new clock face was required before it could replace the original, so I created this branch with the clock face replaced in order to flash it to my device for testing. Eventually I started merging all the other PRs as well and it turned into a Linux style next branch.

Not sure how much testing is enough to be honest. Been running it every day for weeks now, tested every function and have found no issues. What do you think @joeycastillo?

[matheusmoreira]

I'm on mobile at the moment and don't have access to a computer right now. When I get home I'll split the faces up in order to unblock this, assuming Joey hasn't changed his mind.

[theAlexes]

the extensive testing and thorough annotation is quite appreciated, for sure. I think the goal behind having the simple clock face separate from the advanced one is that the simple face serves as a low-complexity example for others to build new faces from, but we'll have to defer to Joey on this.

[matheusmoreira]

Yeah, I have this propensity to making small functions. I personally find it easier to understand but others found to be "Lisp-like", a quality which I didn't even try to refute due to my love of lisp. In my mind the refactored code is easier to understand, but I'll respect it if others don't find it so.

[814d3]

@matheusmoreira, I checked simple clock face and "your" clock face in the online firmware builder. They act different in indicating alarm and hourly chime. Refering to #373 (comment) I thought they should be identically?

[matheusmoreira]

@814d3

They act different in indicating alarm and hourly chime.

Yes. It appears the hourly chime and alarm indicators had been swapped in movement. I noticed this and swapped them back. So clock_face differs from simple_clock_face but matches the stock watch's behavior. This appears to have been the original intention of the maintainers.

[814d3]

Well, what I read about the original watch behavior is, that the bell indicates a hourly signal und the waves a alarm - it's the same for the simple_clock_face, but not in clock_face. But you are right, in the documentation (#373 (comment)) it's swapped and should be corrected.

[matheusmoreira]

@814d3

You're absolutely right about that. I based the decision to switch the icons on the watch library documentation. Turns out the documentation was swapped all along!!

Sensor-Watch/watch-library/shared/watch/watch_slcd.h

Lines 44 to 51 in 439843f

	/// An enum listing the icons and indicators available on the watch.
	typedef enum WatchIndicatorSegment {
	WATCH_INDICATOR_SIGNAL = 0, ///< The hourly signal indicator; also useful for indicating that sensors are on.
	WATCH_INDICATOR_BELL, ///< The small bell indicating that an alarm is set.
	WATCH_INDICATOR_PM, ///< The PM indicator, indicating that a time is in the afternoon.
	WATCH_INDICATOR_24H, ///< The 24H indicator, indicating that the watch is in a 24-hour mode.
	WATCH_INDICATOR_LAP ///< The LAP indicator; the F-91W uses this in its stopwatch UI.
	} WatchIndicatorSegment;

qw593.pdf

There's the alarm-on-mark and the time-signal-on-mark. The watch library documentation says the bell indicates alarms, but on the original module the bell indicates the time signal.

So this should definitely be fixed. Perhaps the fix should happen inside movement at the API level. The constants WATCH_INDICATOR_BELL and WATCH_INDICATOR_SIGNAL refer to the same thing.