Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start and End times seem backwards #10

Open
jlgaustin opened this issue Dec 8, 2016 · 1 comment
Open

Start and End times seem backwards #10

jlgaustin opened this issue Dec 8, 2016 · 1 comment

Comments

@jlgaustin
Copy link

jlgaustin commented Dec 8, 2016

Sleep increments the end time and wake increments the start time. Intuitively this is backwards.

@joedaniels29
Copy link
Owner

Yeah, I think in this repo its somehow ended up backwards. It needs a modest rework, but its not enough to change just the names of the variables, because originally, the logic was meant to go the other way, but one or two bugs ended up piling up, and one or two wrong solutions were proposed, and now its totally reversed. haha. Feel free to submit a PR if you want to comb through the code a bit to fix.

thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants