Getting old warnings even after fixing and saving the file

[ghosty141]

I switched from lsp-mode to eglot, it's going great so far apart from one thing, eglot doesnt seem to "sync" on save. With lsp-mode if some warning persisted after I fixed it, I could just save the file and everything go reevaluated thus eliminating the old warning.

Am I missing something in my configuration? Currently eglot-reconnect kinda works but that is surely not correct.

[joaotavora]

Am I missing something in my configuration?

Likely you have something excessive, not missing, in your configuration. But we can't know because you haven't shown it, so please show it, or better yet, try to reproduce this behavior with a lighter configuration that has just Emacs, Eglot and clangd. If you're using the Emacs 29 pretest that would be even simpler.

It seems you are using clangd and c++. I am using the same, and find no such problems with the simplest of setups:

/poth/to/emacs29/src/emacs -Q some-c++-file.cpp -f eglot

[ghosty141]

Hm I sadly can't really reproduce it right now, even with my full config. This problem doesn't always occur but like maybe 5% of the time so it can get a bit annoying at times. I'll report back once I get some more information.

[ghost]

I had similar issues and here is a repro:

• Run emacs -Q /tmp/test.c;
• M-: (setf flymake-no-changes-timeout nil) RET;
• M-x eglot RET;
• Insert in buffer:

int
main(void)
{
    return 0
}

• Move point right after the "0", and wait for a second;
• Quickly insert ; and save.

Then Flymake reports an error about the semicolon. For me, decreasing the value of eglot-send-changes-idle-time alleviates the problem.

Thanks!

Appendix

• Server used: clangd (version 15.0.6)
• System: GNU/Linux (runs a rather old kernel, 4.15)
• Emacs version: GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu) of 2023-01-26.
• Eglot version: the one comes with Emacs commit d865e180968.
• Contents of eglot-events-buffer:

[internal] Fri Jan 27 11:52:09 2023:
(:message "Running language server: /usr/bin/clangd")
[client-request] (id:1) Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :id 1 :method "initialize" :params
	  (:processId 18937 :rootPath "/tmp/" :rootUri "file:///tmp" :initializationOptions #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 data
													  ())
		      :capabilities
		      (:workspace
		       (:applyEdit t :executeCommand
				   (:dynamicRegistration :json-false)
				   :workspaceEdit
				   (:documentChanges t)
				   :didChangeWatchedFiles
				   (:dynamicRegistration t)
				   :symbol
				   (:dynamicRegistration :json-false)
				   :configuration t :workspaceFolders t)
		       :textDocument
		       (:synchronization
			(:dynamicRegistration :json-false :willSave t :willSaveWaitUntil t :didSave t)
			:completion
			(:dynamicRegistration :json-false :completionItem
					      (:snippetSupport :json-false :deprecatedSupport t :resolveSupport
							       (:properties
								["documentation" "details" "additionalTextEdits"])
							       :tagSupport
							       (:valueSet
								[1]))
					      :contextSupport t)
			:hover
			(:dynamicRegistration :json-false :contentFormat
					      ["plaintext"])
			:signatureHelp
			(:dynamicRegistration :json-false :signatureInformation
					      (:parameterInformation
					       (:labelOffsetSupport t)
					       :activeParameterSupport t))
			:references
			(:dynamicRegistration :json-false)
			:definition
			(:dynamicRegistration :json-false :linkSupport t)
			:declaration
			(:dynamicRegistration :json-false :linkSupport t)
			:implementation
			(:dynamicRegistration :json-false :linkSupport t)
			:typeDefinition
			(:dynamicRegistration :json-false :linkSupport t)
			:documentSymbol
			(:dynamicRegistration :json-false :hierarchicalDocumentSymbolSupport t :symbolKind
					      (:valueSet
					       [1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26]))
			:documentHighlight
			(:dynamicRegistration :json-false)
			:codeAction
			(:dynamicRegistration :json-false :codeActionLiteralSupport
					      (:codeActionKind
					       (:valueSet
						["quickfix" "refactor" "refactor.extract" "refactor.inline" "refactor.rewrite" "source" "source.organizeImports"]))
					      :isPreferredSupport t)
			:formatting
			(:dynamicRegistration :json-false)
			:rangeFormatting
			(:dynamicRegistration :json-false)
			:rename
			(:dynamicRegistration :json-false)
			:publishDiagnostics
			(:relatedInformation :json-false :codeDescriptionSupport :json-false :tagSupport
					     (:valueSet
					      [1 2])))
		       :experimental #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 data
						   ()))
		      :workspaceFolders
		      [(:uri "file:///tmp" :name "/tmp/")]))
[stderr] I[11:52:09.428] clangd version 15.0.6 (https://github.com/conda-forge/clangdev-feedstock b6cf7124da893bcb57ab1f38c768ea825fabbdb1)
[stderr] I[11:52:09.428] Features: linux
[stderr] I[11:52:09.428] PID: 18944
[stderr] I[11:52:09.428] Working directory: /tmp
[stderr] I[11:52:09.428] argv[0]: /usr/bin/clangd
[stderr] I[11:52:09.428] Starting LSP over stdin/stdout
[server-reply] (id:1) Fri Jan 27 11:52:09 2023:
(:id 1 :jsonrpc "2.0" :result
     (:capabilities
      (:astProvider t :callHierarchyProvider t :clangdInlayHintsProvider t :codeActionProvider
		    (:codeActionKinds
		     ["quickfix" "refactor" "info"])
		    :compilationDatabase
		    (:automaticReload t)
		    :completionProvider
		    (:resolveProvider :json-false :triggerCharacters
				      ["." "<" ">" ":" "\"" "/" "*"])
		    :declarationProvider t :definitionProvider t :documentFormattingProvider t :documentHighlightProvider t :documentLinkProvider
		    (:resolveProvider :json-false)
		    :documentOnTypeFormattingProvider
		    (:firstTriggerCharacter "\n" :moreTriggerCharacter
					    [])
		    :documentRangeFormattingProvider t :documentSymbolProvider t :executeCommandProvider
		    (:commands
		     ["clangd.applyFix" "clangd.applyTweak"])
		    :hoverProvider t :implementationProvider t :inlayHintProvider t :memoryUsageProvider t :referencesProvider t :renameProvider t :selectionRangeProvider t :semanticTokensProvider
		    (:full
		     (:delta t)
		     :legend
		     (:tokenModifiers
		      ["declaration" "deprecated" "deduced" "readonly" "static" "abstract" "virtual" "dependentName" "defaultLibrary" "usedAsMutableReference" "functionScope" "classScope" "fileScope" "globalScope"]
		      :tokenTypes
		      ["variable" "variable" "parameter" "function" "method" "function" "property" "variable" "class" "interface" "enum" "enumMember" "type" "type" "unknown" "namespace" "typeParameter" "concept" "type" "macro" "comment"])
		     :range :json-false)
		    :signatureHelpProvider
		    (:triggerCharacters
		     ["(" ")" "{" "}" "<" ">" ","])
		    :standardTypeHierarchyProvider t :textDocumentSync
		    (:change 2 :openClose t :save t)
		    :typeDefinitionProvider t :typeHierarchyProvider t :workspaceSymbolProvider t)
      :serverInfo
      (:name "clangd" :version "clangd version 15.0.6 (https://github.com/conda-forge/clangdev-feedstock b6cf7124da893bcb57ab1f38c768ea825fabbdb1) linux x86_64-unknown-linux-gnu")))
[client-notification] Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :method "initialized" :params #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 data
							    ()))
[client-notification] Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :method "textDocument/didOpen" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c" :version 0 :languageId "c" :text "")))
[client-notification] Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :method "workspace/didChangeConfiguration" :params
	  (:settings #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 data
				   ())))
[stderr] I[11:52:09.428] <-- initialize(1)
[stderr] I[11:52:09.429] --> reply:initialize(1) 0 ms
[stderr] I[11:52:09.430] <-- initialized
[stderr] I[11:52:09.431] <-- textDocument/didOpen
[stderr] I[11:52:09.431] <-- workspace/didChangeConfiguration
[stderr] I[11:52:09.431] Failed to find compilation database for /tmp/test.c
[stderr] I[11:52:09.431] ASTWorker building file /tmp/test.c version 0 with command clangd fallback
[stderr] [/tmp]
[stderr] /usr/lib/llvm-3.8/bin/clang -resource-dir=/usr/lib/clang/15.0.6 -- /tmp/test.c
[server-notification] Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :method "textDocument/publishDiagnostics" :params
	  (:diagnostics
	   []
	   :uri "file:///tmp/test.c" :version 0))
[stderr] I[11:52:09.440] --> textDocument/publishDiagnostics
[client-request] (id:2) Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :id 2 :method "textDocument/signatureHelp" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 0 :character 0)))
[client-request] (id:3) Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :id 3 :method "textDocument/hover" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 0 :character 0)))
[client-request] (id:4) Fri Jan 27 11:52:09 2023:
(:jsonrpc "2.0" :id 4 :method "textDocument/documentHighlight" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 0 :character 0)))
[server-reply] (id:3) Fri Jan 27 11:52:09 2023:
(:id 3 :jsonrpc "2.0" :result nil)
[server-reply] (id:4) Fri Jan 27 11:52:09 2023:
(:id 4 :jsonrpc "2.0" :result
     [])
[stderr] I[11:52:09.935] <-- textDocument/signatureHelp(2)
[stderr] I[11:52:09.935] <-- textDocument/hover(3)
[stderr] I[11:52:09.935] --> reply:textDocument/hover(3) 0 ms
[stderr] I[11:52:09.935] <-- textDocument/documentHighlight(4)
[stderr] I[11:52:09.935] --> reply:textDocument/documentHighlight(4) 0 ms
[stderr] I[11:52:09.937] --> reply:textDocument/signatureHelp(2) 2 ms
[server-reply] (id:2) Fri Jan 27 11:52:09 2023:
(:id 2 :jsonrpc "2.0" :result
     (:activeParameter 0 :activeSignature 0 :signatures
		       []))
[internal] (id:5) Fri Jan 27 11:52:22 2023:
(:deferring :textDocument/signatureHelp :id 5 :params
	    (:textDocument
	     (:uri "file:///tmp/test.c")
	     :position
	     (:line 4 :character 1)))
[internal] (id:6) Fri Jan 27 11:52:22 2023:
(:deferring :textDocument/hover :id 6 :params
	    (:textDocument
	     (:uri "file:///tmp/test.c")
	     :position
	     (:line 4 :character 1)))
[internal] (id:7) Fri Jan 27 11:52:22 2023:
(:deferring :textDocument/documentHighlight :id 7 :params
	    (:textDocument
	     (:uri "file:///tmp/test.c")
	     :position
	     (:line 4 :character 1)))
[client-notification] Fri Jan 27 11:52:22 2023:
(:jsonrpc "2.0" :method "textDocument/didChange" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c" :version 3)
	   :contentChanges
	   [(:range
	     (:start
	      (:line 0 :character 0)
	      :end
	      (:line 0 :character 0))
	     :rangeLength 0 :text "int\nmain(void)\n{\n    return 0\n}")
	    (:range
	     (:start
	      (:line 0 :character 0)
	      :end
	      (:line 4 :character 1))
	     :rangeLength 31 :text "int\nmain(void)\n{\n    return 0\n}")
	    (:range
	     (:start
	      (:line 4 :character 0)
	      :end
	      (:line 4 :character 1))
	     :rangeLength 1 :text "}")]))
[internal] Fri Jan 27 11:52:22 2023:
(:maybe-run-deferred
 (7 6 5))
[client-request] (id:7) Fri Jan 27 11:52:22 2023:
(:jsonrpc "2.0" :id 7 :method "textDocument/documentHighlight" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 4 :character 1)))
[client-request] (id:6) Fri Jan 27 11:52:22 2023:
(:jsonrpc "2.0" :id 6 :method "textDocument/hover" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 4 :character 1)))
[client-request] (id:5) Fri Jan 27 11:52:22 2023:
(:jsonrpc "2.0" :id 5 :method "textDocument/signatureHelp" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 4 :character 1)))
[stderr] I[11:52:22.874] <-- textDocument/didChange
[stderr] I[11:52:22.875] <-- textDocument/documentHighlight(7)
[stderr] I[11:52:22.875] Failed to find compilation database for /tmp/test.c
[stderr] I[11:52:22.875] <-- textDocument/hover(6)
[stderr] I[11:52:22.875] ASTWorker building file /tmp/test.c version 3 with command clangd fallback
[stderr] [/tmp]
[stderr] /usr/lib/llvm-3.8/bin/clang -resource-dir=/usr/lib/clang/15.0.6 -- /tmp/test.c
[stderr] I[11:52:22.875] <-- textDocument/signatureHelp(5)
[server-reply] (id:5) Fri Jan 27 11:52:22 2023:
(:id 5 :jsonrpc "2.0" :result
     (:activeParameter 0 :activeSignature 0 :signatures
		       []))
[stderr] I[11:52:22.877] --> reply:textDocument/signatureHelp(5) 2 ms
[server-reply] (id:7) Fri Jan 27 11:52:22 2023:
(:id 7 :jsonrpc "2.0" :result
     [])
[server-reply] (id:6) Fri Jan 27 11:52:22 2023:
(:id 6 :jsonrpc "2.0" :result nil)
[stderr] I[11:52:22.878] --> reply:textDocument/documentHighlight(7) 3 ms
[stderr] I[11:52:22.878] --> reply:textDocument/hover(6) 3 ms
[server-notification] Fri Jan 27 11:52:22 2023:
(:jsonrpc "2.0" :method "textDocument/publishDiagnostics" :params
	  (:diagnostics
	   [(:code "expected_semi_after_stmt" :message "Expected ';' after return statement (fix available)" :range
		   (:end
		    (:character 1 :line 4)
		    :start
		    (:character 0 :line 4))
		   :severity 1 :source "clang")]
	   :uri "file:///tmp/test.c" :version 3))
[stderr] I[11:52:22.882] --> textDocument/publishDiagnostics
[client-request] (id:8) Fri Jan 27 11:52:25 2023:
(:jsonrpc "2.0" :id 8 :method "textDocument/signatureHelp" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 3 :character 12)))
[client-request] (id:9) Fri Jan 27 11:52:25 2023:
(:jsonrpc "2.0" :id 9 :method "textDocument/hover" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 3 :character 12)))
[client-request] (id:10) Fri Jan 27 11:52:25 2023:
(:jsonrpc "2.0" :id 10 :method "textDocument/documentHighlight" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 3 :character 12)))
[server-reply] (id:9) Fri Jan 27 11:52:25 2023:
(:id 9 :jsonrpc "2.0" :result nil)
[server-reply] (id:10) Fri Jan 27 11:52:25 2023:
(:id 10 :jsonrpc "2.0" :result
     [])
[stderr] I[11:52:25.940] <-- textDocument/signatureHelp(8)
[stderr] I[11:52:25.941] <-- textDocument/hover(9)
[stderr] I[11:52:25.941] --> reply:textDocument/hover(9) 0 ms
[stderr] I[11:52:25.941] <-- textDocument/documentHighlight(10)
[stderr] I[11:52:25.941] --> reply:textDocument/documentHighlight(10) 0 ms
[server-reply] (id:8) Fri Jan 27 11:52:25 2023:
(:id 8 :jsonrpc "2.0" :result
     (:activeParameter 0 :activeSignature 0 :signatures
		       []))
[stderr] I[11:52:25.943] --> reply:textDocument/signatureHelp(8) 2 ms
[internal] (id:5) Fri Jan 27 11:52:32 2023:
(:timed-out :textDocument/signatureHelp :id 5 :params
	    (:textDocument
	     (:uri "file:///tmp/test.c")
	     :position
	     (:line 4 :character 1)))
[internal] (id:6) Fri Jan 27 11:52:32 2023:
(:timed-out :textDocument/hover :id 6 :params
	    (:textDocument
	     (:uri "file:///tmp/test.c")
	     :position
	     (:line 4 :character 1)))
[internal] (id:7) Fri Jan 27 11:52:32 2023:
(:timed-out :textDocument/documentHighlight :id 7 :params
	    (:textDocument
	     (:uri "file:///tmp/test.c")
	     :position
	     (:line 4 :character 1)))
[client-notification] Fri Jan 27 11:52:39 2023:
(:jsonrpc "2.0" :method "textDocument/didChange" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c" :version 7)
	   :contentChanges
	   [(:range
	     (:start
	      (:line 3 :character 12)
	      :end
	      (:line 3 :character 12))
	     :rangeLength 0 :text ";")
	    (:range
	     (:start
	      (:line 3 :character 0)
	      :end
	      (:line 3 :character 4))
	     :rangeLength 4 :text "")
	    (:range
	     (:start
	      (:line 3 :character 0)
	      :end
	      (:line 3 :character 0))
	     :rangeLength 0 :text "  ")
	    (:range
	     (:start
	      (:line 4 :character 1)
	      :end
	      (:line 4 :character 1))
	     :rangeLength 0 :text "\n")]))
[client-notification] Fri Jan 27 11:52:39 2023:
(:jsonrpc "2.0" :method "textDocument/didSave" :params
	  (:text "int\nmain(void)\n{\n  return 0;\n}\n" :textDocument
		 (:uri "file:///tmp/test.c")))
[stderr] I[11:52:39.288] <-- textDocument/didChange
[stderr] I[11:52:39.288] <-- textDocument/didSave
[stderr] I[11:52:39.288] File version went from 7 to 7
[stderr] I[11:52:39.338] Failed to find compilation database for /tmp/test.c
[stderr] I[11:52:39.339] ASTWorker building file /tmp/test.c version 7 with command clangd fallback
[stderr] [/tmp]
[stderr] /usr/lib/llvm-3.8/bin/clang -resource-dir=/usr/lib/clang/15.0.6 -- /tmp/test.c
[server-notification] Fri Jan 27 11:52:39 2023:
(:jsonrpc "2.0" :method "textDocument/publishDiagnostics" :params
	  (:diagnostics
	   []
	   :uri "file:///tmp/test.c" :version 7))
[stderr] I[11:52:39.342] --> textDocument/publishDiagnostics
[client-request] (id:11) Fri Jan 27 11:52:39 2023:
(:jsonrpc "2.0" :id 11 :method "textDocument/signatureHelp" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 3 :character 11)))
[client-request] (id:12) Fri Jan 27 11:52:39 2023:
(:jsonrpc "2.0" :id 12 :method "textDocument/hover" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 3 :character 11)))
[client-request] (id:13) Fri Jan 27 11:52:39 2023:
(:jsonrpc "2.0" :id 13 :method "textDocument/documentHighlight" :params
	  (:textDocument
	   (:uri "file:///tmp/test.c")
	   :position
	   (:line 3 :character 11)))
[server-reply] (id:12) Fri Jan 27 11:52:39 2023:
(:id 12 :jsonrpc "2.0" :result nil)
[server-reply] (id:13) Fri Jan 27 11:52:39 2023:
(:id 13 :jsonrpc "2.0" :result
     [])
[stderr] I[11:52:39.791] <-- textDocument/signatureHelp(11)
[stderr] I[11:52:39.791] <-- textDocument/hover(12)
[stderr] I[11:52:39.791] --> reply:textDocument/hover(12) 0 ms
[stderr] I[11:52:39.791] <-- textDocument/documentHighlight(13)
[stderr] I[11:52:39.791] --> reply:textDocument/documentHighlight(13) 0 ms
[server-reply] (id:11) Fri Jan 27 11:52:39 2023:
(:id 11 :jsonrpc "2.0" :result
     (:activeParameter 0 :activeSignature 0 :signatures
		       []))
[stderr] I[11:52:39.793] --> reply:textDocument/signatureHelp(11) 2 ms

[tshu-w]

Some related discussion and issue.