Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ADFS <4 in addition to 4 or split up the package #3

Open
Kuret opened this issue Feb 13, 2019 · 2 comments
Open

Support ADFS <4 in addition to 4 or split up the package #3

Kuret opened this issue Feb 13, 2019 · 2 comments

Comments

@Kuret
Copy link
Contributor

Kuret commented Feb 13, 2019

Any way we can keep support for older versions?
Or otherwise split this up into separate packages?

We still have a lot of clients with older versions of ADFS that don't have the OAuth+OpenID stuff. (aka no .well-known or /oauth endpoints.)

I guess easiest would be to just fork v2.0 into some kind of legacy package.

Would love to hear your thoughts.
@jmerriweather
Copy link
Owner

We could just keep a branch for v2 and release updates for v2 as needed.
Another option would be to keep both implementations and have a configuration switch. It would be reasonably easy to extract a common interface for both implementations.

@jmerriweather jmerriweather mentioned this issue Mar 4, 2019
Open
@jmerriweather
Copy link
Owner

I've been thinking about this one, I believe the best option would be extracting out the functionality of v2 and being able to specify which ADFS is to be supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmerriweather @Kuret