Compat with Vcov 0.8 and newer FixedEffectModels versions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add I see a failure on nightly but that was there before these changes so warrants a separate investigation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 91.24% 91.18% -0.07%
==========================================
Files 8 8
Lines 914 919 +5
==========================================
+ Hits 834 838 +4
- Misses 80 81 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks, looks good. For some reason the estimates are slightly different on Julia nightly, not sure what's going on (but agree that this is orthogonal to the PR). This should fix #54 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that this is correct, but I've basically changed
VcovDataGLMin the same way thatVcovchanged in the upstream package, and made the relevant changes to functions that use this. I'm not sure I understood the dependency structure betweenVcov,StatsAPIandGLFixedEffectModelsso do check if this makes sense.Unrelated changes:
cholesky!(..., Val(true))but had to make that conditional on version as this was only introduced in 1.7.xvariable local in thenlregtests at the end to get rid of the soft scope warnings.