Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Decouple MakeMkv version from docker build #228

Open
shawnnapora opened this issue Nov 2, 2024 · 1 comment
Open

[Feature request] Decouple MakeMkv version from docker build #228

shawnnapora opened this issue Nov 2, 2024 · 1 comment

Comments

@shawnnapora
Copy link

shawnnapora commented Nov 2, 2024

Idea

MakeMkv updates every few months (see revision history in the downloads page), and after the beta key expires the MakeMkv version must be the latest in order to renew the beta key. This requires updating the docker build itself, and MakeMkv functionality is broken until this repository is updated.

The version of MakeMkv could be specified in an env var (or utilize the default), and the binary could be downloaded into the settings mount if it is missing. The hash file could be optionally be cached and utilized to verify version (e.g. for 1.17.8).

I would be happy to help contribute for this if contributions are welcome. This would allow updates to be consumed immediately by users by bumping the version to use in an environment variable.

(P.S. I really appreciate this containerized version of MakeMkv, thanks for running it all this time!)

@jlesage
Copy link
Owner

jlesage commented Nov 8, 2024

Unfortunately, it is not as simple as replacing a binary. First, this project compiles parts of MakeMKV. Also, due to the minimal environment provided by the container, a new version of MakeMKV is not guaranteed to work in the same environment: MakeMKV may require new or different dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants