Add bme280 #98
Open
Add bme280 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-firmware into add-bme280
# Conflicts: # proto/python/src/soil_power_sensor_protobuf/__init__.py # proto/python/src/soil_power_sensor_protobuf/decode.py # proto/python/src/soil_power_sensor_protobuf/encode.py # proto/python/src/soil_power_sensor_protobuf/soil_power_sensor_pb2.py # stm32/Inc/sensors.h
|
Need to version bump python package before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Submit a pull request
title: ''
labels: ''
assignees: ''
reviewers: 'jmadden173'
Name/Affiliation/Title
John Madden, Maintainer, UCSC
Purpose of the PR
Add support for the bme280 temperature/pressure/humidity sensor.
Development Environment
Linux spruce 6.8.2-arch2-1 #1 SMP PREEMPT_DYNAMIC Thu, 28 Mar 2024 17:06:35 +0000 x86_64 GNU/LinuxPlatformIO Core, version 6.1.7
Used ST-Link V3 MINIE
Test Procedure
Describe the test procedure. For purely software, specifying the unit test is sufficient. Sometimes external configurations are required to test a hardware component. Create a new main in
examples/and describe the expected output. A photo or diagram is very helpful.Additional Context
Every once in a while the sensors read extreme measurements for no apparent reason (See #99). Also modified the
soil-power-sensor-protobuflibrary to include a optional parameter for raw measurements.Closes #87