Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mb85rc1mt #138

Open
wants to merge 7 commits into
base: release/2.2.0
Choose a base branch
from

Conversation

jmadden173
Copy link
Contributor

Name/Affiliation/Title
John, UCSC, maintainer

Purpose of the PR
Closes #136

Development Environment
OS: Linux spruce 6.8.2-arch2-1 #1 SMP PREEMPT_DYNAMIC Thu, 28 Mar 2024 17:06:35 +0000 x86_64 GNU/Linux
Hardware version: 2.2.2 or (2.2.1) with FM16.... chip removed
Software version: N/A
Platformio Version: 6.1.15

Test Procedure
Run unit tests test_fifo and test_fram on hardware version 2.2.2.

Additional Context
In the process I created a method of enabling/disabling support for different fram chips since we need it to be backwards compatible. The fram library has a extern reference that is supplied by each chips library and controlled via in include and define.

Task List

  • Update CHANGELOG.md
  • Static code analysis passes
  • All environments can be built
  • All tests pass
  • Clear documentation for new code
  • Linting passes
  • (If applicable) Version bump python library

@jmadden173 jmadden173 linked an issue Oct 4, 2024 that may be closed by this pull request
@jmadden173 jmadden173 self-assigned this Oct 4, 2024
@jmadden173
Copy link
Contributor Author

The test requires the hardware to be replaced on the remote CI

@jmadden173 jmadden173 changed the base branch from main to release/2.2.0 October 22, 2024 21:25
@jmadden173 jmadden173 removed the request for review from jlin143 October 22, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MB85RC1MT
1 participant